Skip to content

Comments

[4.0] css changes in voting plugin#32919

Merged
drmenzelit merged 6 commits intojoomla:4.0-devfrom
rjharishabh:voting
Apr 15, 2021
Merged

[4.0] css changes in voting plugin#32919
drmenzelit merged 6 commits intojoomla:4.0-devfrom
rjharishabh:voting

Conversation

@rjharishabh
Copy link
Contributor

@rjharishabh rjharishabh commented Mar 28, 2021

Pull Request for Issue #32908.

Actual result BEFORE applying this Pull Request

before voting

Expected result AFTER applying this Pull Request

vote

Documentation Changes Required

No

@rjharishabh rjharishabh changed the title css changes in voting plugin [4.0] css changes in voting plugin Mar 28, 2021
@brianteeman
Copy link
Contributor

why are you changing the height?

@rjharishabh
Copy link
Contributor Author

why are you changing the height?

for mobile users

@infograf768
Copy link
Member

@rjharishabh
Have y7ou tested #31098

@rjharishabh
Copy link
Contributor Author

rjharishabh commented Mar 29, 2021

@rjharishabh
Have y7ou tested #31098

No

@brianteeman
Copy link
Contributor

That was a hint that you probably should

@rjharishabh
Copy link
Contributor Author

That was a hint that you probably should

yeah sure, I will test

@rjharishabh
Copy link
Contributor Author

please test this PR @brianteeman @infograf768

@rjharishabh
Copy link
Contributor Author

rjharishabh commented Mar 29, 2021

I have tested PR #31098

Some error occurred

@rjharishabh
Copy link
Contributor Author

@Quy I think it's fine now

@infograf768
Copy link
Member

I have tested this item ✅ successfully on 859039e


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32919.

@rjharishabh
Copy link
Contributor Author

@infograf768 Thnx for testing

@ceford
Copy link
Contributor

ceford commented Mar 30, 2021

I tested this and it works as described but it seems it will be redundant when #31098 gets merged - and it has a drop-down chevron,


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32919.

@rjharishabh
Copy link
Contributor Author

I think it looks better now

@sandewt
Copy link
Contributor

sandewt commented Mar 31, 2021

I have tested this item 🔴 unsuccessfully on efe66e7

Patch doesn't work in responsive mode


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32919.

@sandewt
Copy link
Contributor

sandewt commented Mar 31, 2021

The patch doesn't work in the responsive mode: see image

screen shot 2021-03-31 at 09 50 05

You can solve this with the following code: 'style' => 'width: 120px;'
This results in:

<?php echo HTMLHelper::_('select.genericlist', $options, 'user_rating', array('class' => 'form-select form-select-sm', 'style' => 'width: 120px;'), 'value', 'text', '5', 'content_vote_' . (int) $row->id); ?>

issue-2
[EDIT]


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32919.

@sandewt
Copy link
Contributor

sandewt commented Mar 31, 2021

I have tested this item ✅ successfully on ee406f1


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32919.

@rjharishabh
Copy link
Contributor Author

Thanks for testing @sandewt

@rjharishabh
Copy link
Contributor Author

please test this PR @infograf768 and @ceford again
there are some changes

@ceford
Copy link
Contributor

ceford commented Mar 31, 2021

I have tested this item ✅ successfully on ee406f1

Works in wide and narrow screen modes. But no css changes in diff and Vote is below <Prev button - a separate issue.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32919.

@Quy
Copy link
Contributor

Quy commented Mar 31, 2021

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32919.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Mar 31, 2021
@Quy Quy added this to the Joomla 4.0 milestone Mar 31, 2021
@rjharishabh
Copy link
Contributor Author

I have tested this item ✅ successfully on ee406f1

Works in wide and narrow screen modes. But no css changes in diff and Vote is below <Prev button - a separate issue.

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32919.

PR #32914

@infograf768
Copy link
Member

imho, I prefer #31098 using svg.

@drmenzelit drmenzelit merged commit 87b8b7a into joomla:4.0-dev Apr 15, 2021
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Apr 15, 2021
@drmenzelit
Copy link
Contributor

Thanks @rjharishabh for your first contribution!
The select field and the button are not aligned correctly, but that can be improved on another PR
grafik

@rjharishabh rjharishabh deleted the voting branch April 16, 2021 06:59
mstrap pushed a commit to mstrap/joomla-cms that referenced this pull request Nov 16, 2021
* css changed in voting

* inlined

* width auto

* space removed

* dropdown added

* responsive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants