[4.0] css changes in voting plugin#32919
[4.0] css changes in voting plugin#32919drmenzelit merged 6 commits intojoomla:4.0-devfrom rjharishabh:voting
Conversation
|
why are you changing the height? |
for mobile users |
|
@rjharishabh |
No |
|
That was a hint that you probably should |
yeah sure, I will test |
|
please test this PR @brianteeman @infograf768 |
|
I have tested PR #31098 Some error occurred |
|
@Quy I think it's fine now |
|
I have tested this item ✅ successfully on 859039e This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32919. |
|
@infograf768 Thnx for testing |
|
I tested this and it works as described but it seems it will be redundant when #31098 gets merged - and it has a drop-down chevron, This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32919. |
|
I think it looks better now |
|
I have tested this item 🔴 unsuccessfully on efe66e7 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32919. |
|
The patch doesn't work in the responsive mode: see image You can solve this with the following code: This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32919. |
|
I have tested this item ✅ successfully on ee406f1 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32919. |
|
Thanks for testing @sandewt |
|
please test this PR @infograf768 and @ceford again |
|
I have tested this item ✅ successfully on ee406f1 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32919. |
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32919. |
PR #32914 |
|
imho, I prefer #31098 using svg. |
|
Thanks @rjharishabh for your first contribution! |
* css changed in voting * inlined * width auto * space removed * dropdown added * responsive



Pull Request for Issue #32908.
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Documentation Changes Required
No