Skip to content

[4.0] fix Media Manager hidden alerts #32868

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
drmenzelit merged 3 commits into from
Mar 26, 2021
Merged

[4.0] fix Media Manager hidden alerts #32868

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a54d4a8
fix
dgrammatiko Mar 25, 2021
a32717c
some todos, if the other alert PRs get merged
dgrammatiko Mar 25, 2021
763854e
CS
dgrammatiko Mar 25, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions administrator/components/com_media/resources/scripts/app/Notifications.es6.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ class Notifications {
success(message, options) {
// eslint-disable-next-line no-use-before-define
notifications.notify(message, {
type: 'message',
type: 'message', // @todo rename it to success
dismiss: true,
...options,
});
Expand All @@ -15,7 +15,7 @@ class Notifications {
error(message, options) {
// eslint-disable-next-line no-use-before-define
notifications.notify(message, {
type: 'error',
type: 'error', // @todo rename it to danger
dismiss: true,
...options,
});
Expand All @@ -30,10 +30,17 @@ class Notifications {
/* Send a notification */
// eslint-disable-next-line class-methods-use-this
notify(message, options) {
let timer;
if (options.type === 'message') {
timer = 3000;
}
Joomla.renderMessages(
{
[options.type]: [Joomla.JText._(message)],
},
undefined,
true,
timer,
);
}
}
Expand Down
2 changes: 1 addition & 1 deletion build/media_source/system/js/core.es6.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -675,7 +675,7 @@ window.Joomla.Modal = window.Joomla.Modal || {
messagesBox.setAttribute('dismiss', 'true');

if (timeout && parseInt(timeout, 10) > 0) {
messagesBox.setAttribute('autodismiss', timeout);
messagesBox.setAttribute('auto-dismiss', timeout);
}

// Title
Expand Down