Skip to content

[4.0] Fixing No-ID setting for nomenu router rule#32695

Merged
rdeutz merged 2 commits intojoomla:4.0-devfrom
Hackwar:j4_nomenu
Mar 17, 2021
Merged

[4.0] Fixing No-ID setting for nomenu router rule#32695
rdeutz merged 2 commits intojoomla:4.0-devfrom
Hackwar:j4_nomenu

Conversation

@Hackwar
Copy link
Member

@Hackwar Hackwar commented Mar 15, 2021

Pull Request for Issue #32248.

Summary of Changes

When generating a URL to a content item that has no menu item leading to it, uses the rule-based-routers AND the "Remove IDs from URLs" option for the component is active, the router can't parse the URL again. This should fix that.

Testing Instructions

  1. In the settings of the contact component, enable "Remove IDs from URLs" and save that.
  2. Create a contact with a tag
  3. Create a menu item of type "Tags -> tagged items" with the previously used tag
  4. Go to the frontend and click on your new menu item.
  5. See the contact being listed and click on it.
  6. You get an error page. Oh no!
  7. Apply the PR.
  8. Reload the page and see that it works fine.

Thanks to @PhilETaylor for reporting this issue with good instructions.

@joomdonation
Copy link
Contributor

Works well for tags, contacts. However, it is not working for com_content yet:

  1. Unpublish all menu items linked to com_content
  2. Publish the Articles - Categories module
  3. That module will display list of categories. Clicks on a category generate links in this format http://localhost/joomla4/index.php/component/content/category/components?Itemid=101 and that links throws 404 error.

@Hackwar
Copy link
Member Author

Hackwar commented Mar 15, 2021

Hopefully this fix should do it. :-)

@richard67
Copy link
Member

@Hackwar Does this replace #20979 ?

@Hackwar
Copy link
Member Author

Hackwar commented Mar 15, 2021

Looking at #20979 this here looks like a better solution. So, yes, close that one.

@joomdonation
Copy link
Contributor

I have tested this item ✅ successfully on ec7cb82

Tested with several core components and it is working well. Thanks.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32695.

@alikon
Copy link
Contributor

alikon commented Mar 16, 2021

I have tested this item ✅ successfully on ec7cb82


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32695.

@alikon
Copy link
Contributor

alikon commented Mar 16, 2021

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32695.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Mar 16, 2021
@Quy Quy added this to the Joomla 4.0 milestone Mar 16, 2021
@rdeutz rdeutz merged commit 5318912 into joomla:4.0-dev Mar 17, 2021
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Mar 17, 2021
@Hackwar Hackwar deleted the j4_nomenu branch March 18, 2021 21:24
@joomleb
Copy link

joomleb commented Jan 11, 2022

Hi guys,
seeing here that the RTC label has been removed on 17 May 2021.
Sorry, but, What about this fix and 4.1 version release ? Will it be added ?
Please, What is planned for this issue ?

@richard67
Copy link
Member

@joomleb rtc has been removed because this pr has been merged, I.e. committed, so it cannot be ready to commit anymore. It has been merged in March last year and so is part of 4.0 and 4.1 since then.

@joomleb
Copy link

joomleb commented Jan 11, 2022

@richard67 Many Thanks for your help in understanding

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants