Skip to content

[4.0-dev] Add limit settings to fancy-select #32591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 18, 2021
Merged

[4.0-dev] Add limit settings to fancy-select #32591

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
f41fc3c
Update joomla-field-fancy-select.w-c.es6.js
thednp Mar 5, 2021
1c865f3
Update joomla-field-fancy-select.w-c.es6.js
thednp Mar 5, 2021
164cc23
Update joomla-field-fancy-select.w-c.es6.js
thednp Mar 5, 2021
057617c
Update joomla-field-fancy-select.w-c.es6.js
thednp Mar 5, 2021
6203cf6
Update joomla-field-fancy-select.w-c.es6.js
thednp Mar 7, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion build/media_source/system/js/fields/joomla-field-fancy-select.w-c.es6.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,9 @@
* min-term-length="1" The minimum length a search value should be before choices are searched.
* placeholder="" The value of the inputs placeholder.
* search-placeholder="" The value of the search inputs placeholder.
*
* data-max-results="30" The maximum amount of search results to be displayed.
* data-max-render="30" The maximum amount of items to be rendered, critical for large lists.
*/
window.customElements.define('joomla-field-fancy-select', class extends HTMLElement {
// Attributes to monitor
Expand Down Expand Up @@ -123,7 +126,8 @@ window.customElements.define('joomla-field-fancy-select', class extends HTMLElem
searchPlaceholderValue: this.searchPlaceholder,
removeItemButton: true,
searchFloor: this.minTermLength,
searchResultLimit: 10,
searchResultLimit: parseInt(this.select.dataset.maxResults, 10) || 10,
renderChoiceLimit: parseInt(this.select.dataset.maxRender, 10) || -1,
shouldSort: false,
fuseOptions: {
threshold: 0.3, // Strict search
Expand Down