Skip to content

[4.0] Hide disabled components in mod_submenu #32555

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wilsonge merged 5 commits into from
Mar 5, 2021
Merged

[4.0] Hide disabled components in mod_submenu #32555

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b131a45
less code
alikon Mar 1, 2021
6c2c13a
better ?
alikon Mar 1, 2021
fa6cc5d
easy read
alikon Mar 2, 2021
abd61d4
unnecessary bracket
alikon Mar 2, 2021
9511451
com_languages
alikon Mar 2, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions administrator/components/com_menus/presets/system.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,25 +127,25 @@
<menuitem
title="MOD_MENU_MANAGE_LANGUAGES"
type="component"
element="com_language"
element="com_languages"
link="index.php?option=com_languages&amp;view=installed"
permission="core.manage;com_language"
permission="core.manage;com_languages"
/>

<menuitem
title="MOD_MENU_MANAGE_LANGUAGES_CONTENT"
type="component"
element="com_language"
element="com_languages"
link="index.php?option=com_languages&amp;view=languages"
permission="core.manage;com_language"
permission="core.manage;com_languages"
/>

<menuitem
title="MOD_MENU_MANAGE_LANGUAGES_OVERRIDES"
type="component"
element="com_language"
element="com_languages"
link="index.php?option=com_languages&amp;view=overrides"
permission="core.manage;com_language"
permission="core.manage;com_languages"
/>

<menuitem
Expand Down
6 changes: 6 additions & 0 deletions administrator/modules/mod_submenu/src/Menu/Menu.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,12 @@ public static function preprocess($parent)

foreach ($children as $item)
{
if ($item->element && !ComponentHelper::isEnabled($item->element))
{
$parent->removeChild($item);
continue;
}

$itemParams = $item->getParams();

// Exclude item with menu item option set to exclude from menu modules
Expand Down