[4.0] Updated switcher.php layout and its corresponding scss files

[thednp]

Summary of Changes

Since the <legend> added to the switch field type is set to use visually-hidden class, with the self explanatory function, all the additional styling is redundant, hence we clean it up.

Pull Request for Issue #32367 (comment) .

Testing Instructions

Simplest way to test:

• go to System - Site Template Styles - Cassiopeia
• go to Advanced tab and inspect the <legend> element of the setting called Layout
• the .switcher__legend class should have no style before merging the [4.0] Update buttons.php layout to latest Bootstrap 5 markup, also added LEGEND markup #32367 into the 4.0 branch

Actual result BEFORE applying this Pull Request

Expected result AFTER applying this Pull Request

No visual or functional change is expected since the target element uses the .visually-hidden class

Documentation Changes Required

No

[brianteeman]

If you are removing the classes from the template css then you should also remove the reference to them in the php markup.

For reference the class was not invented for fun as it did serve a purpose when the code was originally committed by me at #24463.

The code was made useless by changes in #27684 which was when it should have been removed

[thednp]

@brianteeman roger, also updated. Thanks man.

[Quy]

Delete? https://github.com/thednp/joomla-cms/blob/5530359d37f1f38b91cc7815b337a1a633bce254/build/media_source/system/scss/fields/switcher.scss#L104

[Quy]

I have tested this item ✅ successfully on d573b80

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32377.}

[infograf768]

I have tested this item ✅ successfully on d573b80

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32377.}

[infograf768]

RTC

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32377.}

[infograf768]

Tks