Skip to content

Conversation

@brianteeman
Copy link
Contributor

@brianteeman brianteeman commented Jan 30, 2021

Pull Request for #32197 requires npm i

Before

image

After

image

Thanks @dgrammatiko

@joomla-cms-bot joomla-cms-bot added NPM Resource Changed This Pull Request can't be tested by Patchtester PR-4.0-dev labels Jan 30, 2021
@ChristineWk
Copy link

I have tested this item ✅ successfully on 6ede0f6

With Prebuilt package.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32209.

@ghost
Copy link

ghost commented Jan 31, 2021

I have tested this item ✅ successfully on 6ede0f6


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32209.

@infograf768
Copy link
Member

Please follow @Quy suggestion
#32209 (comment)

@infograf768
Copy link
Member

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32209.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jan 31, 2021
@infograf768 infograf768 added this to the Joomla 4.0 milestone Jan 31, 2021
@infograf768 infograf768 merged commit 301c8c3 into joomla:4.0-dev Jan 31, 2021
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Jan 31, 2021
@infograf768
Copy link
Member

merged as it does not change existing tests.

tks

@brianteeman
Copy link
Contributor Author

thanks

@brianteeman brianteeman deleted the subhead branch January 31, 2021 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

NPM Resource Changed This Pull Request can't be tested by Patchtester

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants