[4] Rename and namespace Joomla Commands#31941
[4] Rename and namespace Joomla Commands#31941PhilETaylor wants to merge 1 commit intojoomla:4.0-devfrom PhilETaylor:namepace-commands
Conversation
Signed-off-by: Phil E. Taylor <phil@phil-taylor.com>
This comment was marked as abuse.
This comment was marked as abuse.
|
Hmm I kinda get the aim of this. But at minimum the users and finder things are their own extensions so should be as top level as any other 3rd party extension. Honestly I'm unsure on grouping session/site/extension commands together. I'm going to talk around the maintainers group for opinions. |
|
I have tested this item ✅ successfully on e84dcd8 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31941. |
|
i don't like it |
This comment was marked as abuse.
This comment was marked as abuse.
|
I have tested this item ✅ successfully on e84dcd8 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31941. |
This comment was marked as abuse.
This comment was marked as abuse.
|
The CLI App interface isn't compatible with Joomla's (the default parameter in the |
|
As long as all add-ons namespace their commands (as akeeba has done) I'm not sure I see where the problem lies |
|
Sooner or later it will clash, so better to namespace them yet. |
|
I have tested this item ✅ successfully on e84dcd8 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31941. |
|
I have tested this item ✅ successfully on e84dcd8 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31941. |
|
Ok I've talked in maintainers a little bit. I'm going to close this - I think we've roughly got the right breakdown already - where these are roughly broken down by our internal component names. We can probably group some things together like maybe update and core or similar but I think everything under one name is way too far. |
A decision is needed asap - as a release blocker - because if this is not merged before Joomla 4.0.0 is released, then its a b/c change and will not be worth doing in the future when Joomla 4.1 is released.
Summary of Changes
prefix all Joomla internal commands with
joomla:to correctly namespace them from other commands.Out of the box this doesn't seem to make much sense, however as the community add more and more commands, the name spacing and naming convention of commands can, and will, get messy. This has already played out in other projects with commands.
Testing Instructions
php cli/joomla.php listnote that
database:import/exportis not covered by this PR as that is a library of its own.Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
And after installing extensions with other commands you can see why this is much neater and makes sense to do:
Documentation Changes Required