[4.0] cli remove old files

[brianteeman]

Quick fix to change the success message

Pull Request for Issue #31901

[brianteeman]

Folders is a level of pedantry I'm not going to entertain. The pr addresses the reported issue.

[ceford]

I have tested this item ✅ successfully on 60aaf53

Before the PR the command response is:
[OK] Files removed
After the PR the command response is:
[OK] There are no old files left to remove
So just changing the response message works as described.

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31914.}

[alikon]

this is not correct
put a dummy file at '/administrator/components/com_actionlogs/actionlogs.php',
run php cli/joomla.php update:joomla:remove-old-files

you'll get always the message
[OK] There are no old files left to remove

[brianteeman]

@alikon thats not related. The file you added is not an "old file"

[alikon]

it is an old file https://github.com/joomla/joomla-cms/blob/4.0-dev/administrator/components/com_admin/script.php#L476

[brianteeman]

In that case there is a problem with the script if its not removing files. All this PR does is to modify the string the script outputs on completion. Any issues with the script not working is completely off topic and should have its own issue.

[alikon]

All this PR does is to modify the string the script outputs on completion. Any issues with the script not working is completely off topic and should have its own issue.

which is wrong imho they are strictly related
the correct command output should be

• files/folder removed if 1 or more file/folder file was removed
• no files/folders to remove if no file/folder file was removed

and yes the script.php must be modifyed to return at least a boolean

[brianteeman]

Got to love bikeshedding

[alikon]

still need to fully understand what bikeshedding means
😄 but...

[brianteeman]

I am using it as a term to indicate that the conversation you are having is unrelated to the actual issue. As for your consistent criticism of others people work and only being willing to contribute a spellcheck - everyone knows that you are just a leach who takes from joomla without giving back.