Merged
Conversation
The code that was added to the login module to support the svg icon for webauthn was missing for the users component
|
I have tested this item ✅ successfully on efc2eda This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31824. |
1 similar comment
|
I have tested this item ✅ successfully on efc2eda This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31824. |
Contributor
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31824. |
Member
|
The patch works. No problem. |
Contributor
|
@infograf768 that depends if #31190 is reverted or not. So now we have 4 issues on hold sigh |
Contributor
Author
|
This should be merged as it fixes a problem right now. A new PR can always be created later if needed as a result of any other PR |
Contributor
|
Thanks! |
Contributor
Author
|
thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The code that was added to the login module to support the svg icon for webauthn was missing for the users component
Testing Instructions
Compare the login module and the user login menu item in the front end on a site with https
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request