[4.0][com_content] remove comment from c&p mistake #31659
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
can you fix https://ci.joomla.org/joomla/joomla-cms/38218/1/6 please |
Contributor
Author
|
Sorry didn't understand i've changed only 1 file this administrator/components/com_content/src/Model/ArticleModel.php how it can be related to the drone report |
Member
|
@HLeithner Drone PHPCS is currently failing in the 4.0-dev branch with the same result: https://ci.joomla.org/joomla/joomla-cms/38216/1/6 . So it's not related to this PR, and the branch of this PR is up to date. |
Member
|
I have tested this item ✅ successfully on e32dc05 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31659. |
Contributor
|
I have tested this item ✅ successfully on e32dc05 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31659. |
Contributor
Author
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31659. |
Contributor
|
What was that about not setting RTC on PRs with failing tests? 🤔 |
Member
|
As I stated above, failing tests are not related to this PR but to the 4.0-dev branch. |
brianteeman
added a commit
to brianteeman/joomla-cms
that referenced
this pull request
Dec 15, 2020
As reported in joomla#31659 If drone passes then it should be good to go as its just code style
Closed
Member
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
remove comment from c&p mistake
Testing Instructions
code review