Skip to content

Fix session's moving from Joomla 3 to Joomla 4#31561

Merged
wilsonge merged 1 commit intojoomla:4.0-devfrom
wilsonge:session_migration_j3
Dec 3, 2020
Merged

Fix session's moving from Joomla 3 to Joomla 4#31561
wilsonge merged 1 commit intojoomla:4.0-devfrom
wilsonge:session_migration_j3

Conversation

@wilsonge
Copy link
Contributor

@wilsonge wilsonge commented Dec 3, 2020

@HLeithner did basically all of the debugging work on this so massive massive credit to him! Both me and @zero-24 had unsuccessfully tried to debug this in the past.

Pull Request for Issue #28465 .

Summary of Changes

  • Double encodes the session name for compat with session names in Joomla 3
  • Ensures the code that is stored within a session namespace (concept removed in the framework) continues to function during the lifetime of J4 to allow stable upgrades from J3 (it's worth noting that in the future if users go from Joomla 3 to Joomla 4 and straight a J5 where this migration code has been removed there could be issues - but I'm taking this as another bridge for another day)
  • Removes the session migration step that was left over from 3.4.7 session security issues as we require users to go via 3.10 all users will have had their session migrated so this code is useless anyhow.

Testing Instructions

Test by upgrading from Joomla 3.x to this 4.x repo. Before you'll get logged out during the upgrade. After patch you will stay logged in

Documentation Changes Required

None

@HLeithner did 90% of the debugging work on this so massive credit to him!

Test by upgrading from Joomla 3.x to this 4.x repo. Before you'll get logged out during the upgrade. After patch you will stay logged in
@wilsonge wilsonge merged commit a14aa96 into joomla:4.0-dev Dec 3, 2020
@wilsonge wilsonge deleted the session_migration_j3 branch December 3, 2020 01:01
@wilsonge
Copy link
Contributor Author

wilsonge commented Dec 3, 2020

Well I didn't mean to merge this - but I managed to forget to swap branches when i started on the next batch on conflicts and git push'd it to 4.0. So I guess this is merged.... At least it get's into nightlies for testing :/

@wilsonge wilsonge added this to the Joomla 4.0 milestone Dec 3, 2020
@infograf768
Copy link
Member

It totally breaks my test site here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Comments