Skip to content

[4.0] #29722 hidden recaptcha v2#31454

Merged
laoneo merged 7 commits intojoomla:4.0-devfrom
hans2103:#29722-hidden-recaptcha-v2
Nov 30, 2020
Merged

[4.0] #29722 hidden recaptcha v2#31454
laoneo merged 7 commits intojoomla:4.0-devfrom
hans2103:#29722-hidden-recaptcha-v2

Conversation

@hans2103
Copy link
Contributor

Pull Request for Issue #29722 .

Summary of Changes

This PR will add inline styling for the Google invisible reCaptcha v2 and prevents it from hiding behind other elements by adding a huge z-index.

Testing Instructions

Actual result BEFORE applying this Pull Request

Google invisible reCaptcha v2 badge is hiding behind other blocks

Expected result AFTER applying this Pull Request

Google invisible reCaptcha v2 badge is in front of other blocks

Documentation Changes Required

@brianteeman
Copy link
Contributor

can it please be done without using an inline style

@hans2103
Copy link
Contributor Author

@brianteeman I was not able to find the exact location of the inline styles on the element. And loading an extra css file when this plugin is enabled does not seem to be a better solution then using the proposed style element.

@ceford
Copy link
Contributor

ceford commented Nov 22, 2020

I have tested this item ✅ successfully on 5bf6e64

It works as described, although getting a V2 Key is a pain. It seems to me the obvious place to put the style is in template.css. Will other template developers want to use a different z-index?


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31454.

@brianteeman
Copy link
Contributor

@hans2103 the aim is to try and remove inline styles - not easy - but we certainly should not be adding any. This is to allow stricter CSP policies for security.

cc @zero-24 @wilsonge

@ghost
Copy link

ghost commented Nov 25, 2020

I have tested this item ✅ successfully on 5bf6e64


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31454.

@Quy
Copy link
Contributor

Quy commented Nov 25, 2020

@hans2103 You can see how it is done in PR #31098.

@hans2103
Copy link
Contributor Author

@Quy I know how it is done. The reason I added is using inline styling was to prevent an extra httpRequest.

@joomla-cms-bot joomla-cms-bot added the NPM Resource Changed This Pull Request can't be tested by Patchtester label Nov 26, 2020
@richard67
Copy link
Member

@ceford @Gostn This PR has received changes. Could you test again? Thanks in advance.

@ceford
Copy link
Contributor

ceford commented Nov 26, 2020

I have tested this item ✅ successfully on 39fa0ea

It still works. Do we have any information on the extra time needed to fetch a style sheet containing one line?


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31454.

@Fedik
Copy link
Member

Fedik commented Nov 26, 2020

The reason I added is using inline styling was to prevent an extra httpRequest.

You can add it to existing template css, no need inline css or separated css file.
It is template styling issue, not reCaptcha issue

@ghost
Copy link

ghost commented Nov 26, 2020

I have tested this item ✅ successfully on 39fa0ea


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31454.

@richard67 richard67 removed the NPM Resource Changed This Pull Request can't be tested by Patchtester label Nov 26, 2020
@richard67
Copy link
Member

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31454.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Nov 26, 2020
@laoneo laoneo added this to the Joomla 4.0 milestone Nov 30, 2020
@laoneo laoneo merged commit fc55f96 into joomla:4.0-dev Nov 30, 2020
@joomla-cms-bot joomla-cms-bot added NPM Resource Changed This Pull Request can't be tested by Patchtester and removed RTC This Pull Request is Ready To Commit labels Nov 30, 2020
@laoneo
Copy link
Member

laoneo commented Nov 30, 2020

Thanks!

@hans2103 hans2103 deleted the #29722-hidden-recaptcha-v2 branch November 30, 2020 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

NPM Resource Changed This Pull Request can't be tested by Patchtester

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants