[4.0] Login/Logout page image description [a11y]

[brianteeman]

Continues the work of #31318 and #31323 by correcting the behaviour of the alt text and changing the strings to match the work done in #31318

This is very slightly different to the other similar PR as before this PR the alt text for the login image was hardcoded and the alt text for the logout page was an untranslated string. In addition the login and logout sections of the options have now been correctly placed into their own fieldsets

Background

To read why this change is very important see #31318

Testing Part 1

Testing is really easy. No npm, js or css involved.
Merge the pull request and then create a Login form menu item and add an image for the login and logout

Testing Part 2

1. Image Description (Alt Text) = Empty
   No Description = unchecked

2. Image Description (Alt Text) = "some description"
   No Description = unchecked

3. Image Description (Alt Text) = Empty
   No Description = checked

The expected behaviour for each of these tests is

1.<img src="filename.jpg">
2. <img src="filename.jpg" alt="some description">
3. <img src="filename.jpg" alt >
or <img src="filename.jpg" alt="">

PLEASE do not comment on what you think the code does but apply the PR and test it. Getting very tired of people blocking PR with their comments without actually testing the code.

cc @carcam

[carcam]

@brianteeman I think this image is most of the time decorative, what do you think about making checkbox checked by default?

[ceford]

I am seeing a problem: in scenario 3, with Image Description empty and No Description checked, I get alt="2" for both login and logout image.

<img src="/joomla-cms-4/images/sampledata/parks/landscape/180px_ormiston_pound.jpg" class="com-users-logout__image thumbnail float-right logout-image" alt="2">

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31360.}

[brianteeman]

@carcam It is impossible to guess that the image is usually decorative and anyway it is better if we are consistent across joomla

@ceford good spot I will look at that

[carcam]

@brianteeman you are right. Consistancy is key for a better usability. Thanks!!!

[vaibhavsTekdi]

I have tested this item 🔴 unsuccessfully on dad9c4d

What I found is,

• It gets failed at 3rd scenario i.e.

Image Description (Alt Text) = Empty
No Description = checked

it gives the result having an only src tag for the image & not the alt or alt=""
it gives the result having an only src tag for the image & not the alt or alt=""

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31360.}

[punambaravkar]

I have tested this item 🔴 unsuccessfully on dad9c4d

I found problem: in scenario 3, with Image Description empty and No Description checked, I get result having an only src tag for the image & not the alt or alt=""

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31360.}

[brianteeman]

I have fixed the conflicts and the reported bug. Please retest

[bonzani]

I have tested this item ✅ successfully on b3c7957

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31360.}

[ghost]

I have tested this item ✅ successfully on b3c7957

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31360.}

[HLeithner]

Thanks

[brianteeman]

Thanks