Skip to content

Comments

[4.0] Newsfeeds image alt#31357

Merged
HLeithner merged 1 commit intojoomla:4.0-devfrom
brianteeman:newsfeed
Dec 5, 2020
Merged

[4.0] Newsfeeds image alt#31357
HLeithner merged 1 commit intojoomla:4.0-devfrom
brianteeman:newsfeed

Conversation

@brianteeman
Copy link
Contributor

Continues the work of #31318 and #31323 by correcting the behaviour of the alt text and changing the strings to match the work done in #31318

Background

To read why this change is very important see #31318

Testing Part 1

Testing is really easy. No npm, js or css involved.
Merge the pull request and then create a newsfeed (you can use https://community.joomla.org/blogs/community.feed and in the options add a first and second image

image

Testing Part 2

Please test three scenarios when you display the newsfeed from the menu

  1. Image Description (Alt Text) = Empty
    No Description = unchecked

  2. Image Description (Alt Text) = "some description"
    No Description = unchecked

  3. Image Description (Alt Text) = Empty
    No Description = checked

The expected behaviour for each of these tests is

1.<img src="filename.jpg">
2. <img src="filename.jpg" alt="some description">
3. <img src="filename.jpg" alt >
or <img src="filename.jpg" alt="">

PLEASE do not comment on what you think the code does but apply the PR and test it. Getting very tired of people blocking PR with their comments without actually testing the code.

cc @carcam

@richard67
Copy link
Member

Strange, this PR doesn't appear in the issue tracker.

@Quy
Copy link
Contributor

Quy commented Nov 16, 2020

Tested successfully.

@BertaOctech
Copy link

Hi,
Is this issue waiting for tests?


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31357.

@alikon
Copy link
Contributor

alikon commented Nov 26, 2020

yes 👍

@snehal0904
Copy link
Contributor

Tested successfully.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31357.

@richard67
Copy link
Member

@snehal0904 Could you mark your test result in the issue tracker? Just go to the PR here https://issues.joomla.org/tracker/joomla-cms/31357 , use the "Test this" button, select the appropriate test result and the submit. Thanks in advance.

@ghost
Copy link

ghost commented Dec 5, 2020

@snehal0904 please mark your test as successfully at issue-tracker.

@snehal0904
Copy link
Contributor

@Gostn I tried this but I don't know why for this particular issue Test this button is not present.

@ghost
Copy link

ghost commented Dec 5, 2020

@snehal0904 you're right, there is no test this-button for this pr; don't know why.

@Quy Quy added the RTC This Pull Request is Ready To Commit label Dec 5, 2020
@HLeithner HLeithner merged commit eb29c45 into joomla:4.0-dev Dec 5, 2020
@HLeithner
Copy link
Member

Thanks

@joomla-cms-bot joomla-cms-bot added Language Change This is for Translators and removed RTC This Pull Request is Ready To Commit labels Dec 5, 2020
@HLeithner HLeithner added this to the Joomla 4.0 milestone Dec 5, 2020
@brianteeman
Copy link
Contributor Author

thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Language Change This is for Translators

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants