Merged
Conversation
Member
|
Strange, this PR doesn't appear in the issue tracker. |
Contributor
|
Tested successfully. |
|
Hi, This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31357. |
Contributor
|
yes 👍 |
Contributor
|
Tested successfully. This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31357. |
Member
|
@snehal0904 Could you mark your test result in the issue tracker? Just go to the PR here https://issues.joomla.org/tracker/joomla-cms/31357 , use the "Test this" button, select the appropriate test result and the submit. Thanks in advance. |
|
@snehal0904 please mark your test as successfully at issue-tracker. |
Contributor
|
@Gostn I tried this but I don't know why for this particular issue Test this button is not present. |
|
@snehal0904 you're right, there is no test this-button for this pr; don't know why. |
Member
|
Thanks |
Contributor
Author
|
thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continues the work of #31318 and #31323 by correcting the behaviour of the alt text and changing the strings to match the work done in #31318
Background
To read why this change is very important see #31318
Testing Part 1
Testing is really easy. No npm, js or css involved.
Merge the pull request and then create a newsfeed (you can use https://community.joomla.org/blogs/community.feed and in the options add a first and second image
Testing Part 2
Please test three scenarios when you display the newsfeed from the menu
Image Description (Alt Text) = Empty
No Description = unchecked
Image Description (Alt Text) = "some description"
No Description = unchecked
Image Description (Alt Text) = Empty
No Description = checked
The expected behaviour for each of these tests is
1.
<img src="filename.jpg">2.
<img src="filename.jpg" alt="some description">3.
<img src="filename.jpg" alt >or
<img src="filename.jpg" alt="">PLEASE do not comment on what you think the code does but apply the PR and test it. Getting very tired of people blocking PR with their comments without actually testing the code.
cc @carcam