[4.0] Atum logo and login image alt [a11y]#31349
Merged
chmst merged 1 commit intojoomla:4.0-devfrom Nov 10, 2020
Merged
Conversation
This PR applies the ALT text changes from joomla#31318 In addition the related fields are now correctly grouped in a fieldset **Any comments about the layout will be ignored as that's an unrelated issue which we have a release blocker for** Testing Testing is really easy. No npm, js or css involved. Merge the pull request and then go to edit an article on both the admin and site. For the site you might need to enable the frontend images and urls option in the component. You now have a new field and tweaked text Please test three scenarios when adding an intro image Image Description (Alt Text) = Empty No Description = unchecked Image Description (Alt Text) = "some description" No Description = unchecked Image Description (Alt Text) = Empty No Description = checked The expected behaviour for each of these tests is <img loading="lazy" src="filename.jpg" itemprop="thumbnailUrl"> <img loading="lazy" src="filename.jpg" alt="some description" itemprop="thumbnailUrl"> <img loading="lazy" src="filename.jpg" alt itemprop="thumbnailUrl"> or <img loading="lazy" src="filename.jpg" alt="" itemprop="thumbnailUrl"> PLEASE do not comment on what you think the code does but apply the PR and test it. Getting very tired of people blocking PR with their comments without actually testing the code.
|
I have tested this item ✅ successfully on b7f157c This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31349. |
1 similar comment
|
I have tested this item ✅ successfully on b7f157c This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31349. |
Member
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31349. |
Contributor
|
Thanks! |
Contributor
Author
|
Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR applies the ALT text changes from #31318
In addition the related fields are now correctly grouped in a fieldset
Any comments about the layout will be ignored as that's an unrelated issue which we have a release blocker for
Testing
Testing is really easy. No npm, js or css involved.
Merge the pull request and then go to edit the atum template style and go to the image settings tab
You now have a new field and tweaked text
Please test three scenarios when adding a large log, a small logo and a login image
Image Description (Alt Text) = Empty
No Description = unchecked
Image Description (Alt Text) = "some description"
No Description = unchecked
Image Description (Alt Text) = Empty
No Description = checked
The expected behaviour for each of these tests is
<img src="filename.jpg"><img src="filename.jpg" alt="some description"><img src="filename.jpg" alt>or
<img src="filename.jpg" alt="">PLEASE do not comment on what you think the code does but apply the PR and test it. Getting very tired of people blocking PR with their comments without actually testing the code.
cc @carcam