[4.0] Fix Tags Compact list bug

[infograf768]

Summary of Changes

Users Notes Categories and Banners Categories can be tagged.
I guess because of the common code for category params.

As they do not have a frontend display layout (normal) they should not have a link to display them in the Tag lists (Compact and normal list).
The code is OK in the normal list

joomla-cms/components/com_tags/tmpl/tag/default_items.php

Lines 81 to 90 in 7044520

	<?php if (($item->type_alias === 'com_users.category') || ($item->type_alias === 'com_banners.category')) : ?>
	<h3>
	<?php echo $this->escape($item->core_title); ?>
	</h3>
	<?php else : ?>
	<h3>
	<a href="<?php echo Route::_($item->link); ?>">
	<?php echo $this->escape($item->core_title); ?>
	</a>
	</h3>

But was forgotten in the Compact list menu item layout, therefore getting a link for these Titles and evidently a 404 if clicked.
This PR corrects list_items to solve the bug.

Testing Instructions

Create a tag.
Tag a few items with that tag, including a banners category and a User Notes Category.
Create a Compact List of tagged items menu item.
Display in frontend.

Actual result BEFORE applying this Pull Request

Clickable titles

Expected result AFTER applying this Pull Request

No more clickable link

Note:

There are other issues with the queries in /libraries/src/Helper/TagsHelper.php. Will create an issue for this.

[ChristineWk]

I have tested this item ✅ successfully on ab3eadf

I don't usually use tags. That's why I'm always happy to receive your exact test instructions :-)

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31093.}

[ChristineWk]

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31093.}

[ghost]

I have tested this item ✅ successfully on ab3eadf

thanks for clear test instructions.

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31093.}

[infograf768]

RTC

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31093.}

[drmenzelit]

Thanks