-
-
Notifications
You must be signed in to change notification settings - Fork 3.8k
[4.0] Created a HTMLHelper to render an icon #30792
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
44 commits
Select commit
Hold shift + click to select a range
c14be3c
Created a HTMLHelper to render an icon
hans2103 7b27c78
clean code
hans2103 7d651df
remove hard coded icon
hans2103 67495f6
https://github.com/joomla/joomla-cms/pull/30792#pullrequestreview-497…
hans2103 37679ba
Update libraries/src/HTML/HTMLHelper.php
hans2103 de4d0a1
Update libraries/src/HTML/HTMLHelper.php
hans2103 a3d7b64
remove $html and $children. Add $srOnly
hans2103 3babe70
apply HTMLHelper icon including sr-only
hans2103 a39a884
move function to libraries/src/HTML/Helpers/Icons.php
hans2103 883cbd0
:wastebasket: housecleaning and apply suggestions by @degobbis
hans2103 0595258
add missing className
hans2103 9788848
Merge branch '4.0-dev' into feature/htmlhelper-for-an-icon
hans2103 93feeb3
Merge branch 'upstream/4.0-dev' into feature/htmlhelper-for-an-icon
hans2103 7b15551
Update libraries/src/HTML/Helpers/Icons.php
hans2103 247e055
Update libraries/src/HTML/Helpers/Icons.php
hans2103 1a950bf
apply Joomla! Coding Standards for DocBlock
hans2103 7bdf486
replace null by '', since variable is a string and default value null…
hans2103 c2bf10e
check if variable isset and not empty
hans2103 b4b4358
Update libraries/src/HTML/Helpers/Icons.php
hans2103 a38142d
Update libraries/src/HTML/Helpers/Icons.php
hans2103 22e613d
Update libraries/src/HTML/Helpers/Icons.php
hans2103 a414b84
removal trim
hans2103 846466f
#30707 has not been merged yet. :-)
hans2103 62c833c
remove default icon and add if-then statement to check existence of icon
hans2103 1df96a3
Merge branch 'upstream/4.0-dev' into feature/htmlhelper-for-an-icon
hans2103 04c3854
replace return '' by throw
hans2103 6465af8
Update libraries/src/HTML/Helpers/Icons.php
hans2103 5589002
Update administrator/language/en-GB/lib_joomla.ini
hans2103 2a943c4
Update libraries/src/HTML/Helpers/Icons.php
hans2103 b1660ab
Merge branch 'upstream/4.0-dev' into feature/htmlhelper-for-an-icon
hans2103 631ab06
added translation to frontend too
hans2103 cb05e07
removal period
hans2103 f884d3f
Merge branch 'upstream/4.0-dev' into feature/htmlhelper-for-an-icon
hans2103 c6e07c6
Merge branch 'upstream/4.0-dev' into feature/htmlhelper-for-an-icon
hans2103 8947ace
reapply change
hans2103 d37a47c
Merge branch 'upstream/4.0-dev' into htmlhelper-for-an-icon
hans2103 2fd362e
FontAwesome provides svg icons... use them
hans2103 8ddfcde
no idea how to explain the test instructions for this. :-)
hans2103 7043049
easier for test instructions... after apply path the icons on dashboa…
hans2103 413191f
add new parameter $type to trigger svg icons
hans2103 83551d9
adjust settings.json
hans2103 3b0314c
call helper icons.icon with svg
hans2103 c91b14c
optimize icons.icon for svg
hans2103 4a765c5
only set sr-only text when aria-hidden is true
hans2103 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -255,6 +255,7 @@ | |
| }, | ||
| "filesExtra": { | ||
| "scss": "scss", | ||
| "svgs": "images", | ||
| "webfonts": "webfonts" | ||
| }, | ||
| "provideAssets": [ | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.