move opening and closing php of message#30759
Closed
hans2103 wants to merge 1 commit intojoomla:4.0-devfrom
hans2103:patch-7
Closed
move opening and closing php of message#30759hans2103 wants to merge 1 commit intojoomla:4.0-devfrom hans2103:patch-7
hans2103 wants to merge 1 commit intojoomla:4.0-devfrom
hans2103:patch-7
Conversation
Contributor
|
hmm in layout files we usally have an opening and an closing php tag per line as per our coding rules. Can you give us more context so we might find a better solution for that issue? |
Contributor
Author
|
.... moment... will adjust my PR... I have an idea |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue # .
Summary of Changes
When styling the messages and spacing around it I would like to be able to hide the message box when empty.
Because the opening of PHP starts on a new line there is some obsolete spacing rendered.
When PR is merged the empty message box will appear together with its spacing
Testing Instructions
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Documentation Changes Required