Skip to content

Comments

move opening and closing php of message#30759

Closed
hans2103 wants to merge 1 commit intojoomla:4.0-devfrom
hans2103:patch-7
Closed

move opening and closing php of message#30759
hans2103 wants to merge 1 commit intojoomla:4.0-devfrom
hans2103:patch-7

Conversation

@hans2103
Copy link
Contributor

Pull Request for Issue # .

Summary of Changes

When styling the messages and spacing around it I would like to be able to hide the message box when empty.

#system-message:empty {
    display: none;
}

Because the opening of PHP starts on a new line there is some obsolete spacing rendered.
When PR is merged the empty message box will appear together with its spacing

Testing Instructions

  • Joomla 4 install
  • Inspect element

Actual result BEFORE applying this Pull Request

<div id="system-message">
			</div>

Expected result AFTER applying this Pull Request

<div id="system-message"></div>

Documentation Changes Required

@zero-24
Copy link
Contributor

zero-24 commented Sep 25, 2020

hmm in layout files we usally have an opening and an closing php tag per line as per our coding rules. Can you give us more context so we might find a better solution for that issue?

@hans2103
Copy link
Contributor Author

.... moment... will adjust my PR... I have an idea

@hans2103
Copy link
Contributor Author

@zero-24 closing in favor of #30760

@hans2103 hans2103 closed this Sep 25, 2020
@hans2103 hans2103 deleted the patch-7 branch November 24, 2020 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants