Skip to content

[4.0] Remove Cassiopeias "_card.scss" override#30754

Merged
wilsonge merged 1 commit intojoomla:4.0-devfrom
Bakual:4_RemoveCardSCSS
Sep 24, 2020
Merged

[4.0] Remove Cassiopeias "_card.scss" override#30754
wilsonge merged 1 commit intojoomla:4.0-devfrom
Bakual:4_RemoveCardSCSS

Conversation

@Bakual
Copy link
Contributor

@Bakual Bakual commented Sep 24, 2020

Since PR #30734 is already RTC this is a followup to remove the Cassiopeia Override for Bootstrap cards.
That file only contains two additional card specific classes: "card-grey" and "card-inverse".

A very similar effect like those two classes can be achieved by using the standard Bootstrap colour classes (see https://getbootstrap.com/docs/4.5/utilities/colors/):
image

Summary of Changes

Deleting the whole file and the reference in the template.

Testing Instructions

  • Apply PR
  • run "npm run build.css" to regenerate the template CSS file
  • Compare module output and other appearance of card layouts (are there any?)
  • Add "card-grey" and "card-inverse" to a module class and assign that module to a position with actually uses the card chrome (eg top-b or sidebars).

Actual result BEFORE applying this Pull Request

The module has a slight darker greyish background with "card-grey" and text becomes white with "card-inverse"

Expected result AFTER applying this Pull Request

The classes have no effect anymore.

Documentation Changes Required

None

@joomla-cms-bot joomla-cms-bot added NPM Resource Changed This Pull Request can't be tested by Patchtester PR-4.0-dev labels Sep 24, 2020
@wilsonge wilsonge merged commit 1179464 into joomla:4.0-dev Sep 24, 2020
@wilsonge
Copy link
Contributor

Thanks!

@wilsonge wilsonge added this to the Joomla 4.0 milestone Sep 24, 2020
@Bakual Bakual deleted the 4_RemoveCardSCSS branch September 24, 2020 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

NPM Resource Changed This Pull Request can't be tested by Patchtester

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments