[4.0] Align content info block icons#30543
Merged
Quy merged 8 commits intojoomla:4.0-devfrom Sep 6, 2020
N6REJ:content-info-block
Merged
[4.0] Align content info block icons#30543Quy merged 8 commits intojoomla:4.0-devfrom N6REJ:content-info-block
Quy merged 8 commits intojoomla:4.0-devfrom
N6REJ:content-info-block
Conversation
Contributor
|
I have tested this item ✅ successfully on 8decde9 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30543. |
|
I have tested this item ✅ successfully on 8decde9 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30543. |
Contributor
|
thinking out aloud - any reason not to just make all icons fixes width |
Contributor
Recommended in any case for vertical menus with different icons. This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30543. |
Member
|
Let’s wait for @wilsonge reply about the use of fontawesome in front end before merging this. |
Contributor
Author
|
@infograf768 it can be merged as if it needs to change the entire core of how icons function will need to change. |
Contributor
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30543. |
Contributor
|
Thanks. |
sakiss
pushed a commit
to sakiss/joomla-cms
that referenced
this pull request
Oct 16, 2020
* convert if (icon) to switch (icon) * revert to using mapped fix. * multi-reverts * make icons even width * reverted improper change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue # .
Summary of Changes
makes all info-block icons fixed with so things line up.
Testing Instructions
install "blog" sample data.
go to administrator/index.php?option=com_menus&view=item&client_id=0&layout=edit&id=103
change red options to match as shown.
go to "about" page in front end..
verify icons show.
verify icons & text line up.
inspect icons to be sure the icon class ends in "fa-fw"
Actual result BEFORE applying this Pull Request
Content & Icons didn't line up
Expected result AFTER applying this Pull Request
everything is visually lined up.
Documentation Changes Required
none