[4.0] Url Language Code is not a prefix by infograf768 · Pull Request #30440 · joomla/joomla-cms

infograf768 · 2020-08-21T10:55:56Z

Pull Request for Issue #30438

Summary of Changes

Reinstating 3.x value. Added back a description, although shorter than in 3.x

Testing Instructions

Patch and edit a Content Language.

Actual result BEFORE applying this Pull Request

Expected result AFTER applying this Pull Request

@MartijnMaandag

brianteeman · 2020-08-21T10:59:16Z

administrator/language/en-GB/com_languages.ini

 COM_LANGUAGES_ERROR_LANGUAGE_METAFILE_MISSING="Could not load %s language meta XML file from %s."
 COM_LANGUAGES_FIELD_IMAGE_LABEL="Image"
-COM_LANGUAGES_FIELD_LANG_CODE_LABEL="URL Language Prefix"
+COM_LANGUAGES_FIELD_LANG_CODE_DESC="This Language Code will be appended to the site URL. Note <em>the Language Code must be unique among all the languages</em>."


Dont you mean domain name not url?

Not as we ever seen it.
The domain name is and remains
mydomain.com
the url is modified to add the url language code after the domain name. mydomain.com/en/ thus making it part of the url.
It is specially obvious when using the parameter Remove URL Language Code in the language filter plugin.
In that case the url language code is not displayed at all.

You are not appending it to the URL. That would be example.com/contact/fr

Also. When sef is off the url language code is added as &lang=en, far way from the domain name.

Both scenarios have in common that it is added (not appended) to the url (once as path prefix and once as query parameter). Append to the url would mean it always ends up at the end of the url.

This is the 3.x string we have since multilang was implemented in J:

COM_LANGUAGES_FIELD_LANG_CODE_DESC="This Language Code will be appended to the site URL. When SEF is enabled, you will get https://example.com/en/. If SEF is disabled the suffix &lang=en will be appended at the end of the URL. Note the Language Code must be unique among all the languages."

I have no issue using another verb than « appended »

Would « added in the site URLs » be acceptable?

From my point of view that would be correct (synonymous 'embedded' would also be possible). Nice to see that you made the text a lot shorter.

" will be included in the site URL"

ok for that. will do later.

ChristineWk · 2020-08-21T15:00:27Z

I have tested this item ✅ successfully on 57519bc

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30440.}

bonzani · 2020-08-21T15:48:45Z

I have tested this item ✅ successfully on 57519bc

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30440.}

infograf768 · 2020-08-21T15:52:55Z

Please do not rtc until I modify the text.

infograf768 · 2020-08-21T16:13:42Z

RTC as the only change is for the description which is now

COM_LANGUAGES_FIELD_LANG_CODE_DESC="This Language Code will be included in the site URL. Note the Language Code must be unique among all the languages."

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30440.}

* [4.0] URL LANGUAGE CODE is not a prefix * modified desc as suggested

@Quy

* First step to make newsflash horizontal * [4.0] Fix Alert double error display in Installation * seperating multiple messages with border top * Increase minimum length * Fix meter displaying complete message prematurely * Add strenthmeter attribute to installation * Change meter values to display green when password requirements are met * [4.0] {Cassiopea] Implementing Password length/meter * [4.0] Fix Fieldset description display (#30435) * [4.0] Url Language Code is not a prefix (#30440) * [4.0] URL LANGUAGE CODE is not a prefix * modified desc as suggested * [4.0] Implementing display of fieldset descriptions for fieldset children * Taking off description * scss cs * use @Quy suggestion * file cs * [4.0] Media field fix (#30455) * fix * typo, (well nothing new) * Allow media fields in subforms - Cleanup Media field - Expose initilazation method of Bootstrpa Modlas to a Joomla.Bootstrap object - Initilise Modlas on the lifecycle of the Custom Element * Paleolithic js mode only in the legacy… * CS * Proper check * Pffff * Update joomla-field-media.w-c.es6.js * [4.0] Convert icon used for jgrid defaults to fas fa- (#30464) * make icon-circle use fa-circle * allows for including icon- in call * move fa-fw to last class to fit convention (#30469) * [4.0] Long labels wrapping (#30474) When we have fields displayed in columns with the label displayed above the input there is a width limit of 240px on the label. This results in long labels wrapping when it is not needed as the column is wider than 240px. In english we dont see this is many places but the easiest is in the __configure edit screen_ fields This simple PR changes the label width to 100% when the fields are displayed in columns like this. As this is an scss change you will need to `node build.js --compile-css` in order to test ### Before ### After * Fix mod_articles_latest (#30459) * [4.0] Add a parameter for "back-to-top" button in Cassiopeia (#30441) * [4.0] Add a parameter for back-to-top button in Cassiopeia Added a parameter to show / hide the back-to-top button in Cassiopeia. Currently the footer appears when a module has been published on position "footer". And the back-to-top only appears if the footer is visible. Since the footer is part of the grid, it is not easy to move the back-to-top outside the grid. Now it is possible to decide to have a back-to-top or not. If yes, the footer will be rendered showing the button, independently if there is a module in the position footer. It is also possible to show only modules (switch back-to-top off) or modules and back-to-top (switch on). * Added smooth scrolling Add smooth scrolling taking in account the preferences of the user (reduced motion). Improve language file. * Correct height and position of back-to-top button * Correct code style * Correct code style 2 * Change smooth scrolling behavior to take in account reduced motion preferences * Language file corrected, language string changed to match others * Update language/en-GB/tpl_cassiopeia.ini Link instead button Co-authored-by: Brian Teeman <brian@teeman.net> * Update templates/cassiopeia/scss/blocks/_global.scss Comment for smooth scroll Co-authored-by: Brian Teeman <brian@teeman.net> Co-authored-by: Brian Teeman <brian@teeman.net> * fix improper family name. (#30481) * [4.0] update helptoc (#30490) * [4.0] update helptoc Removes the string for the expired cache page that no longer exists and removes it from the index displayed on the left hand side in the help page * api * [4.0] Add new permissions-policy to the HTTPHeaders Plugin (#30491) * add permissions-policy * add Permissions-Policy to the dropdown * alpha order * [4.0] Error when changing status of tagged content items (#30466) * Correct column name * Fix changing UCM state * [4.0] br tag (#30503) * [4.0] br tag In Joomla 4 we use ` ` not ` ` * bad grep * [4.0] Remove old search component (#30506) * [4.0] Remove old search component The regular search component is not in J4 This pr removes reference to it in the help system `administrator/index.php?option=com_admin&view=help` * revert * [4.0] Help Dashboard (#30508) * [4.0] Help Dashboard This PR makes multiple changes to the help dashboard. In order of importance they are. - Created a new section "Start Here" - Moved "Joomla Help" to the "Start Here" section to give it greater priority as it really is the first place you should look for help - Removed target=_blank from "Joomla Help" - Moved "Documentation Wiki" from "Resources" to the top of "Additional Help" * deduplicate * compass icon * Moved css for mod_articles_news to media folder User webAsset Manager to load specific css for module * Move web asset call to horizontal.php Co-authored-by: Jean-Marie Simonet <infografjms@gmail.com> Co-authored-by: Quy <quy@fluxbb.org> Co-authored-by: dGrammatiko <d.grammatiko@gmail.com> Co-authored-by: Bear <programming@hallhome.us> Co-authored-by: Brian Teeman <brian@teeman.net> Co-authored-by: Christiane Maier-Stadtherr <dev@chmst.de> Co-authored-by: Tobias Zulauf <zero-24@users.noreply.github.com> Co-authored-by: SharkyKZ <sharkykz@gmail.com>

* [4.0] URL LANGUAGE CODE is not a prefix * modified desc as suggested

@Quy

* First step to make newsflash horizontal * [4.0] Fix Alert double error display in Installation * seperating multiple messages with border top * Increase minimum length * Fix meter displaying complete message prematurely * Add strenthmeter attribute to installation * Change meter values to display green when password requirements are met * [4.0] {Cassiopea] Implementing Password length/meter * [4.0] Fix Fieldset description display (joomla#30435) * [4.0] Url Language Code is not a prefix (joomla#30440) * [4.0] URL LANGUAGE CODE is not a prefix * modified desc as suggested * [4.0] Implementing display of fieldset descriptions for fieldset children * Taking off description * scss cs * use @Quy suggestion * file cs * [4.0] Media field fix (joomla#30455) * fix * typo, (well nothing new) * Allow media fields in subforms - Cleanup Media field - Expose initilazation method of Bootstrpa Modlas to a Joomla.Bootstrap object - Initilise Modlas on the lifecycle of the Custom Element * Paleolithic js mode only in the legacy… * CS * Proper check * Pffff * Update joomla-field-media.w-c.es6.js * [4.0] Convert icon used for jgrid defaults to fas fa- (joomla#30464) * make icon-circle use fa-circle * allows for including icon- in call * move fa-fw to last class to fit convention (joomla#30469) * [4.0] Long labels wrapping (joomla#30474) When we have fields displayed in columns with the label displayed above the input there is a width limit of 240px on the label. This results in long labels wrapping when it is not needed as the column is wider than 240px. In english we dont see this is many places but the easiest is in the __configure edit screen_ fields This simple PR changes the label width to 100% when the fields are displayed in columns like this. As this is an scss change you will need to `node build.js --compile-css` in order to test ### Before ### After * Fix mod_articles_latest (joomla#30459) * [4.0] Add a parameter for "back-to-top" button in Cassiopeia (joomla#30441) * [4.0] Add a parameter for back-to-top button in Cassiopeia Added a parameter to show / hide the back-to-top button in Cassiopeia. Currently the footer appears when a module has been published on position "footer". And the back-to-top only appears if the footer is visible. Since the footer is part of the grid, it is not easy to move the back-to-top outside the grid. Now it is possible to decide to have a back-to-top or not. If yes, the footer will be rendered showing the button, independently if there is a module in the position footer. It is also possible to show only modules (switch back-to-top off) or modules and back-to-top (switch on). * Added smooth scrolling Add smooth scrolling taking in account the preferences of the user (reduced motion). Improve language file. * Correct height and position of back-to-top button * Correct code style * Correct code style 2 * Change smooth scrolling behavior to take in account reduced motion preferences * Language file corrected, language string changed to match others * Update language/en-GB/tpl_cassiopeia.ini Link instead button Co-authored-by: Brian Teeman <brian@teeman.net> * Update templates/cassiopeia/scss/blocks/_global.scss Comment for smooth scroll Co-authored-by: Brian Teeman <brian@teeman.net> Co-authored-by: Brian Teeman <brian@teeman.net> * fix improper family name. (joomla#30481) * [4.0] update helptoc (joomla#30490) * [4.0] update helptoc Removes the string for the expired cache page that no longer exists and removes it from the index displayed on the left hand side in the help page * api * [4.0] Add new permissions-policy to the HTTPHeaders Plugin (joomla#30491) * add permissions-policy * add Permissions-Policy to the dropdown * alpha order * [4.0] Error when changing status of tagged content items (joomla#30466) * Correct column name * Fix changing UCM state * [4.0] br tag (joomla#30503) * [4.0] br tag In Joomla 4 we use ` ` not ` ` * bad grep * [4.0] Remove old search component (joomla#30506) * [4.0] Remove old search component The regular search component is not in J4 This pr removes reference to it in the help system `administrator/index.php?option=com_admin&view=help` * revert * [4.0] Help Dashboard (joomla#30508) * [4.0] Help Dashboard This PR makes multiple changes to the help dashboard. In order of importance they are. - Created a new section "Start Here" - Moved "Joomla Help" to the "Start Here" section to give it greater priority as it really is the first place you should look for help - Removed target=_blank from "Joomla Help" - Moved "Documentation Wiki" from "Resources" to the top of "Additional Help" * deduplicate * compass icon * Moved css for mod_articles_news to media folder User webAsset Manager to load specific css for module * Move web asset call to horizontal.php Co-authored-by: Jean-Marie Simonet <infografjms@gmail.com> Co-authored-by: Quy <quy@fluxbb.org> Co-authored-by: dGrammatiko <d.grammatiko@gmail.com> Co-authored-by: Bear <programming@hallhome.us> Co-authored-by: Brian Teeman <brian@teeman.net> Co-authored-by: Christiane Maier-Stadtherr <dev@chmst.de> Co-authored-by: Tobias Zulauf <zero-24@users.noreply.github.com> Co-authored-by: SharkyKZ <sharkykz@gmail.com>

[4.0] URL LANGUAGE CODE is not a prefix

57519bc

joomla-cms-bot added Language Change This is for Translators PR-4.0-dev labels Aug 21, 2020

infograf768 mentioned this pull request Aug 21, 2020

COM_LANGUAGES_FIELD_LANG_CODE_LABEL #30438

Closed

brianteeman reviewed Aug 21, 2020

View reviewed changes

modified desc as suggested

3c7f8be

joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Aug 21, 2020

Quy merged commit 90b0e1b into joomla:4.0-dev Aug 21, 2020

joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Aug 21, 2020

Quy added this to the Joomla 4.0 milestone Aug 21, 2020

infograf768 deleted the 4.0_languagecode_string branch August 21, 2020 18:23

jgerman-bot mentioned this pull request Aug 21, 2020

[4.0] Url Language Code is not a prefix joomlagerman/joomla#1193

Closed

infograf768 mentioned this pull request Aug 23, 2020

Description not visible when I hover over labels. #30451

Closed

drmenzelit pushed a commit to drmenzelit/joomla-cms that referenced this pull request Aug 31, 2020

[4.0] Url Language Code is not a prefix (joomla#30440)

c5e2472

* [4.0] URL LANGUAGE CODE is not a prefix * modified desc as suggested

sakiss pushed a commit to sakiss/joomla-cms that referenced this pull request Oct 16, 2020

[4.0] Url Language Code is not a prefix (joomla#30440)

bb52fb0

* [4.0] URL LANGUAGE CODE is not a prefix * modified desc as suggested

Uh oh!

Conversation

infograf768 commented Aug 21, 2020

Summary of Changes

Testing Instructions

Actual result BEFORE applying this Pull Request

Expected result AFTER applying this Pull Request

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

infograf768 Aug 21, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ChristineWk commented Aug 21, 2020

Uh oh!

bonzani commented Aug 21, 2020

Uh oh!

infograf768 commented Aug 21, 2020

Uh oh!

infograf768 commented Aug 21, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Comments

infograf768 Aug 21, 2020 •

edited

Loading