[4.0] Remove coloring from icons#30415
Merged
Quy merged 1 commit intojoomla:4.0-devfrom Aug 19, 2020
SharkyKZ:j4/scss/icons
Merged
[4.0] Remove coloring from icons#30415Quy merged 1 commit intojoomla:4.0-devfrom SharkyKZ:j4/scss/icons
Quy merged 1 commit intojoomla:4.0-devfrom
SharkyKZ:j4/scss/icons
Conversation
Member
|
Can you post a screenshot of where it would show? |
Contributor
Author
|
Anywhere. This just makes that publish/unpublish icons get their color from text like any other icon. |
Contributor
|
I have tested this item ✅ successfully on 82809cf This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30415. |
1 similar comment
Member
|
I have tested this item ✅ successfully on 82809cf This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30415. |
Member
|
rtc This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30415. |
sakiss
pushed a commit
to sakiss/joomla-cms
that referenced
this pull request
Oct 16, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Removes explicit colors from these two icons.
Testing Instructions
node build.js --compile-cssrequired.Add some icons somewhere. E.g.:
Actual result BEFORE applying this Pull Request
icon-publishandicon-unpublishare invisible against white background.Expected result AFTER applying this Pull Request
Icons are same color.
Documentation Changes Required
No.