[4.0] Fix multilingual status icons colors#30411
Merged
Quy merged 1 commit intojoomla:4.0-devfrom Aug 19, 2020
Merged
Conversation
Contributor
|
I have tested this item ✅ successfully on 54317b9 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30411. |
1 similar comment
Member
|
I have tested this item ✅ successfully on 54317b9 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30411. |
Member
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30411. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Icons now need coloring via bootstrap text-success and text-danger.
Testing Instructions
Install a few languages (fr-FR, de-DE).
Install a multilingual site via sample data plugin
Trash one of the content languages
Delete a home page for one of the languages
Actual result BEFORE applying this Pull Request
Icons are white on white
Expected result AFTER applying this Pull Request
Note
Similar issue in Users Permissions manager where the text-danger is missing
Will be for another PR