Skip to content

Comments

[4.0] Fix multilingual status icons colors#30411

Merged
Quy merged 1 commit intojoomla:4.0-devfrom
infograf768:4.0_multilingualstatus_icons
Aug 19, 2020
Merged

[4.0] Fix multilingual status icons colors#30411
Quy merged 1 commit intojoomla:4.0-devfrom
infograf768:4.0_multilingualstatus_icons

Conversation

@infograf768
Copy link
Member

Summary of Changes

Icons now need coloring via bootstrap text-success and text-danger.

Testing Instructions

Install a few languages (fr-FR, de-DE).
Install a multilingual site via sample data plugin
Trash one of the content languages
Delete a home page for one of the languages

Actual result BEFORE applying this Pull Request

Icons are white on white

Screen Shot 2020-08-18 at 18 06 24

Expected result AFTER applying this Pull Request

Screen Shot 2020-08-18 at 18 00 03

Note

Similar issue in Users Permissions manager where the text-danger is missing
Will be for another PR

@Quy
Copy link
Contributor

Quy commented Aug 18, 2020

I have tested this item ✅ successfully on 54317b9


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30411.

1 similar comment
@richard67
Copy link
Member

I have tested this item ✅ successfully on 54317b9


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30411.

@richard67
Copy link
Member

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30411.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Aug 18, 2020
@Quy Quy added this to the Joomla 4.0 milestone Aug 19, 2020
@Quy Quy merged commit 5418c28 into joomla:4.0-dev Aug 19, 2020
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Aug 19, 2020
@infograf768 infograf768 deleted the 4.0_multilingualstatus_icons branch August 19, 2020 18:46
sakiss pushed a commit to sakiss/joomla-cms that referenced this pull request Oct 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants