Skip to content

Comments

[4.0] Fix Alert multiple error display#30401

Merged
rdeutz merged 2 commits intojoomla:4.0-devfrom
infograf768:4.0_alert_errors_installation
Aug 21, 2020
Merged

[4.0] Fix Alert multiple error display#30401
rdeutz merged 2 commits intojoomla:4.0-devfrom
infograf768:4.0_alert_errors_installation

Conversation

@infograf768
Copy link
Member

@infograf768 infograf768 commented Aug 17, 2020

Pull Request for Issue #30391

Summary of Changes

Installation Alerts are using the js. The <div> was misplaced.
I added a class but it is not necessary when using default core Installation.

Testing Instructions

Install a clean Joomla using a superuser password shorter than 12 characters

Patch, use NPM CI and install again

EDIT: To test multiple alerts in backend, add in Atum index.php

Factory::getApplication()->enqueueMessage('error message','error');
Factory::getApplication()->enqueueMessage('another long error message','error');
Factory::getApplication()->enqueueMessage('another very long error message','error');
Factory::getApplication()->enqueueMessage('warning message','warning');
Factory::getApplication()->enqueueMessage('warning message','warning');
Factory::getApplication()->enqueueMessage('notice message','notice');

Actual result BEFORE applying this Pull Request

image

Expected result AFTER applying this Pull Request

Screen Shot 2020-08-17 at 15 39 28

@brianteeman @chmst

@joomla-cms-bot joomla-cms-bot added NPM Resource Changed This Pull Request can't be tested by Patchtester PR-4.0-dev labels Aug 17, 2020
@brianteeman
Copy link
Contributor

I am wondering if it is obvious that there are two separate error messages

@brianteeman
Copy link
Contributor

Perhaps adding this divider line helps?

.alert-message:not(:first-of-type) {
    border-top: 1px solid var(--alert-accent-color);
}

image

@infograf768
Copy link
Member Author

Looks good. Will test tomorrow.

@infograf768
Copy link
Member Author

It would look good for long messages in Installation but not really in admin.

Screen Shot 2020-08-17 at 19 05 22

@chmst
Copy link
Contributor

chmst commented Aug 17, 2020

In admin, multiple messages are really rare. And if they occur, it is worth to give them place. So it looks good for me.

@infograf768 infograf768 changed the title [4.0] Fix Alert multiple error display in Installation [4.0] Fix Alert multiple error display Aug 18, 2020
@infograf768
Copy link
Member Author

In fact I succeeded adding the border.
Can be tested during installation as well as in back-end or frontend.
Updated Testing instructions.

Screen Shot 2020-08-18 at 07 36 35

Screen Shot 2020-08-18 at 07 30 20

Please @chmst and @brianteeman test again.

@chmst
Copy link
Contributor

chmst commented Aug 20, 2020

I have tested this item ✅ successfully on 131d19a


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30401.

1 similar comment
@Quy
Copy link
Contributor

Quy commented Aug 20, 2020

I have tested this item ✅ successfully on 131d19a


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30401.

@Quy
Copy link
Contributor

Quy commented Aug 20, 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30401.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Aug 20, 2020
@rdeutz rdeutz merged commit 628f6fe into joomla:4.0-dev Aug 21, 2020
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Aug 21, 2020
@infograf768 infograf768 added this to the Joomla 4.0 milestone Aug 21, 2020
@infograf768 infograf768 deleted the 4.0_alert_errors_installation branch August 21, 2020 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

NPM Resource Changed This Pull Request can't be tested by Patchtester

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants