[4.0] Fix Alert multiple error display#30401
Merged
rdeutz merged 2 commits intojoomla:4.0-devfrom Aug 21, 2020
Merged
Conversation
Contributor
|
I am wondering if it is obvious that there are two separate error messages |
Contributor
Member
Author
|
Looks good. Will test tomorrow. |
Member
Author
Contributor
|
In admin, multiple messages are really rare. And if they occur, it is worth to give them place. So it looks good for me. |
Member
Author
|
In fact I succeeded adding the border. Please @chmst and @brianteeman test again. |
Contributor
|
I have tested this item ✅ successfully on 131d19a This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30401. |
1 similar comment
Contributor
|
I have tested this item ✅ successfully on 131d19a This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30401. |
Contributor
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30401. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




Pull Request for Issue #30391
Summary of Changes
Installation Alerts are using the js. The
<div>was misplaced.I added a class but it is not necessary when using default core Installation.
Testing Instructions
Install a clean Joomla using a superuser password shorter than 12 characters
Patch, use NPM CI and install again
EDIT: To test multiple alerts in backend, add in Atum index.php
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
@brianteeman @chmst