[4.0] Fix broken installation with SQL error on PostgreSQL databases#30327
Merged
HLeithner merged 1 commit intojoomla:4.0-devfrom Aug 10, 2020
Conversation
richard67
changed the title
Contributor
|
I have tested this item ✅ successfully on ffd1881 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30327. |
Contributor
|
after drone finish this can be merged @richard67 |
Member
Author
|
Yes we can count drone as 2nd tester, but I'd prefer if someone else merges it because I'm the author. |
Member
|
Thanks |
Member
Author
|
Welcome. |
richard67
deleted the
4.0-dev-fix-broken-postgresql-installation-from-pr30192
branch
This was referenced Aug 10, 2020
Merged
sakiss
pushed a commit
to sakiss/joomla-cms
that referenced
this pull request
Oct 16, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue # .
Summary of Changes
Since the merge of PR #30192 , the installation on PostgreSQL databases is broken.
You can see that by the
system-tests-postgresconstantly failing on the 4.0-dev branch.Testing Instructions
Code review and check that
system-tests-postgressucceeds in Drone, or make a new installation using a PostgreSQL database.Actual result BEFORE applying this Pull Request
Installation fails with SQL error when using a PostgreSQL database.
Expected result AFTER applying this Pull Request
Installation succeeds when using a PostgreSQL database.
Documentation Changes Required
None.