Conversation
Contributor
|
Merging thanks @joomdonation 👍 |
brianteeman
added a commit
to brianteeman/joomla-cms
that referenced
this pull request
Jul 5, 2020
After PR joomla#29978 this corrects the comment
Merged
zero-24
pushed a commit
that referenced
this pull request
Jul 5, 2020
After PR #29978 this corrects the comment
sakiss
pushed a commit
to sakiss/joomla-cms
that referenced
this pull request
Oct 16, 2020
sakiss
pushed a commit
to sakiss/joomla-cms
that referenced
this pull request
Oct 16, 2020
After PR joomla#29978 this corrects the comment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue # .
Summary of Changes
This PR fixes a typo in sortable method of SortableList helper class. The helper class is DraggableList, not DragableList and the method is draggable, not dragable (see https://github.com/joomla/joomla-cms/blob/4.0-dev/libraries/src/HTML/Helpers/DraggableList.php#L45)
Testing Instructions
Code review should be enough. I found this while testing my extension on Joomla 4 nightly build.