Skip to content

Comments

[4.0] com_redirect bulk import [a11y]#29907

Merged
Quy merged 2 commits intojoomla:4.0-devfrom
brianteeman:thu8
Jul 2, 2020
Merged

[4.0] com_redirect bulk import [a11y]#29907
Quy merged 2 commits intojoomla:4.0-devfrom
brianteeman:thu8

Conversation

@brianteeman
Copy link
Contributor

Every input must have a label.

This PR changes the text in the bulk import modal from a <p> to a <label>

There is no visual change

Every input must have a label.

This PR changes the text in the bulk import modal from a `<p>` to a `<label>`

There is no visual change
@Quy
Copy link
Contributor

Quy commented Jul 2, 2020

I have tested this item ✅ successfully on 65346ef


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29907.

1 similar comment
@ChristineWk
Copy link

I have tested this item ✅ successfully on 65346ef


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29907.

@Quy
Copy link
Contributor

Quy commented Jul 2, 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29907.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jul 2, 2020
@Quy Quy added this to the Joomla 4.0 milestone Jul 2, 2020
@Quy Quy merged commit 4e1013a into joomla:4.0-dev Jul 2, 2020
@brianteeman
Copy link
Contributor Author

thanks

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Jul 2, 2020
@brianteeman brianteeman deleted the thu8 branch July 2, 2020 22:20
sakiss pushed a commit to sakiss/joomla-cms that referenced this pull request Oct 16, 2020
* [4.0] com_redirect bulk import [a11y]

Every input must have a label.

This PR changes the text in the bulk import modal from a `<p>` to a `<label>`

There is no visual change

* typo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants