Skip to content

Comments

[4.0] Fix missing $ for scss variable cassiopeia-grid-gutter#29856

Merged
wilsonge merged 1 commit intojoomla:4.0-devfrom
hans2103:origin/feature/scss-fix-cassiopeia-grid-gutter
Jun 30, 2020
Merged

[4.0] Fix missing $ for scss variable cassiopeia-grid-gutter#29856
wilsonge merged 1 commit intojoomla:4.0-devfrom
hans2103:origin/feature/scss-fix-cassiopeia-grid-gutter

Conversation

@hans2103
Copy link
Contributor

Pull Request for Issue # .

Summary of Changes

This PR just adds a missing $ to a scss variable

Testing Instructions

  • npm run build:css to compile the css
  • check the css output
  • apply PR
  • npm run build:css to compile the css
  • check the css output and compare

Actual result BEFORE applying this Pull Request

.site-grid .container-component > div + div,
.site-grid .container-sidebar-left > div + div,
.site-grid .container-sidebar-right > div + div {
   margin-top: cassiopeia-grid-gutter;
}

Expected result AFTER applying this Pull Request

.site-grid .container-component > div + div,
.site-grid .container-sidebar-left > div + div,
.site-grid .container-sidebar-right > div + div {
   margin-top: 15px;
}

Documentation Changes Required

No changes required

@joomla-cms-bot joomla-cms-bot added NPM Resource Changed This Pull Request can't be tested by Patchtester PR-4.0-dev labels Jun 30, 2020
@Quy
Copy link
Contributor

Quy commented Jun 30, 2020

I have tested this item ✅ successfully on 1885f24


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29856.

@wilsonge wilsonge merged commit 9497c4d into joomla:4.0-dev Jun 30, 2020
@wilsonge
Copy link
Contributor

Merged with the good test and on review

@wilsonge wilsonge added this to the Joomla 4.0 milestone Jun 30, 2020
@hans2103 hans2103 deleted the origin/feature/scss-fix-cassiopeia-grid-gutter branch June 30, 2020 18:23
sakiss pushed a commit to sakiss/joomla-cms that referenced this pull request Oct 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

NPM Resource Changed This Pull Request can't be tested by Patchtester

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants