Skip to content

[4.0] Move event listener from joomla-toolbar-button to button element#29852

Merged
wilsonge merged 1 commit intojoomla:4.0-devfrom
SharkyKZ:j4/js/joomla-toolbar-button
Jun 30, 2020
Merged

[4.0] Move event listener from joomla-toolbar-button to button element#29852
wilsonge merged 1 commit intojoomla:4.0-devfrom
SharkyKZ:j4/js/joomla-toolbar-button

Conversation

@SharkyKZ
Copy link
Contributor

@SharkyKZ SharkyKZ commented Jun 30, 2020

Fixes #29820.

Summary of Changes

Moves event listener from joomla-toolbar-button element to actual clickable button.

Testing Instructions

node build.js --compile-js required.
Go to any backend view containing toolbar buttons.
Click a couple of pixels below or above a button.

Actual result BEFORE applying this Pull Request

Button clicked.

Expected result AFTER applying this Pull Request

Button not clicked.
Also check that buttons continue to work properly.

Documentation Changes Required

No.

@joomla-cms-bot joomla-cms-bot added NPM Resource Changed This Pull Request can't be tested by Patchtester PR-4.0-dev labels Jun 30, 2020
@PhilETaylor

This comment was marked as abuse.

1 similar comment
@Quy
Copy link
Contributor

Quy commented Jun 30, 2020

I have tested this item ✅ successfully on c653e7f


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29852.

@Quy Quy removed NPM Resource Changed This Pull Request can't be tested by Patchtester PR-4.0-dev labels Jun 30, 2020
@Quy
Copy link
Contributor

Quy commented Jun 30, 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29852.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jun 30, 2020
@Quy Quy added the PR-4.0-dev label Jun 30, 2020
@wilsonge wilsonge merged commit 16f284f into joomla:4.0-dev Jun 30, 2020
@wilsonge
Copy link
Contributor

Thanks!

@joomla-cms-bot joomla-cms-bot added NPM Resource Changed This Pull Request can't be tested by Patchtester and removed RTC This Pull Request is Ready To Commit labels Jun 30, 2020
@zero-24 zero-24 added this to the Joomla 4.0 milestone Jun 30, 2020
@Fedik

This comment has been minimized.

@SharkyKZ
Copy link
Contributor Author

SharkyKZ commented Jul 5, 2020

@Fedik I'm aware this was related to styling. But I think this PR is semantically correct. joomla-toolbar-button is not a button and requires a button or a element inside, according to this comment:

// We need a button to support button behavior,
// because we cannot currently extend HTMLButtonElement

sakiss pushed a commit to sakiss/joomla-cms that referenced this pull request Oct 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

NPM Resource Changed This Pull Request can't be tested by Patchtester

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants

Comments