[4.0] Move event listener from joomla-toolbar-button to button element#29852
Merged
wilsonge merged 1 commit intojoomla:4.0-devfrom Jun 30, 2020
SharkyKZ:j4/js/joomla-toolbar-button
Merged
[4.0] Move event listener from joomla-toolbar-button to button element#29852wilsonge merged 1 commit intojoomla:4.0-devfrom SharkyKZ:j4/js/joomla-toolbar-button
wilsonge merged 1 commit intojoomla:4.0-devfrom
SharkyKZ:j4/js/joomla-toolbar-button
Conversation
This comment was marked as abuse.
This comment was marked as abuse.
1 similar comment
Contributor
|
I have tested this item ✅ successfully on c653e7f This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29852. |
Contributor
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29852. |
Contributor
|
Thanks! |
This comment has been minimized.
This comment has been minimized.
Contributor
Author
|
@Fedik I'm aware this was related to styling. But I think this PR is semantically correct. |
sakiss
pushed a commit
to sakiss/joomla-cms
that referenced
this pull request
Oct 16, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #29820.
Summary of Changes
Moves event listener from
joomla-toolbar-buttonelement to actual clickable button.Testing Instructions
node build.js --compile-jsrequired.Go to any backend view containing toolbar buttons.
Click a couple of pixels below or above a button.
Actual result BEFORE applying this Pull Request
Button clicked.
Expected result AFTER applying this Pull Request
Button not clicked.
Also check that buttons continue to work properly.
Documentation Changes Required
No.