Conversation
Usually badges with counts are displayed with the count over the corner not by the side. As this is a scss change you need to `node build.js --compile-css` to test ### before ### after
joomla-cms-bot
added
NPM Resource Changed
Contributor
|
I have tested this item ✅ successfully on f4eb51a This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29847. |
1 similar comment
Member
|
I have tested this item ✅ successfully on f4eb51a This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29847. |
joomla-cms-bot
removed
NPM Resource Changed
Member
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29847. |
joomla-cms-bot
added
NPM Resource Changed
Contributor
Author
|
Thanks |
sakiss
pushed a commit
to sakiss/joomla-cms
that referenced
this pull request
Oct 16, 2020
Usually badges with counts are displayed with the count over the corner not by the side. As this is a scss change you need to `node build.js --compile-css` to test ### before ### after
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Usually badges with counts are displayed with the count over the corner not by the side.
As this is a scss change you need to
node build.js --compile-cssto testbefore
after