Skip to content

Comments

[4.0] Add unit tests for AccessiblemediaField#29440

Merged
wilsonge merged 2 commits intojoomla:4.0-devfrom
astridx:testmedia2
Jun 7, 2020
Merged

[4.0] Add unit tests for AccessiblemediaField#29440
wilsonge merged 2 commits intojoomla:4.0-devfrom
astridx:testmedia2

Conversation

@astridx
Copy link
Contributor

@astridx astridx commented Jun 5, 2020

Pull Request for #27712 .

Summary of Changes

i added Tests

Testing Instructions

Code review and/or run the unit tests like explained here.

@richard67
Copy link
Member

richard67 commented Jun 6, 2020

I have tested this item ✅ successfully on 5a89caf

With this PR 9 more unit tests are executed than without this PR.

When running the unit tests with option "--debug", logging into a log file and comparing the results with and whout the PR, you can see following tests are executed in addition:

Test 'Joomla\Tests\Unit\Libraries\Cms\Form\Field\AccessiblemediaFieldTest::testIsConstructable' started
Test 'Joomla\Tests\Unit\Libraries\Cms\Form\Field\AccessiblemediaFieldTest::testIsConstructable' ended
Test 'Joomla\Tests\Unit\Libraries\Cms\Form\Field\AccessiblemediaFieldTest::testGetWithDefaultValues' started
Test 'Joomla\Tests\Unit\Libraries\Cms\Form\Field\AccessiblemediaFieldTest::testGetWithDefaultValues' ended
Test 'Joomla\Tests\Unit\Libraries\Cms\Form\Field\AccessiblemediaFieldTest::testSetAndGetShouldBeEquals' started
Test 'Joomla\Tests\Unit\Libraries\Cms\Form\Field\AccessiblemediaFieldTest::testSetAndGetShouldBeEquals' ended
Test 'Joomla\Tests\Unit\Libraries\Cms\Form\Field\AccessiblemediaFieldTest::testSetAndGetShouldNotBeEquals' started
Test 'Joomla\Tests\Unit\Libraries\Cms\Form\Field\AccessiblemediaFieldTest::testSetAndGetShouldNotBeEquals' ended
Test 'Joomla\Tests\Unit\Libraries\Cms\Form\Field\AccessiblemediaFieldTest::testSetupWithEmptyValue' started
Test 'Joomla\Tests\Unit\Libraries\Cms\Form\Field\AccessiblemediaFieldTest::testSetupWithEmptyValue' ended
Test 'Joomla\Tests\Unit\Libraries\Cms\Form\Field\AccessiblemediaFieldTest::testSetupWithValueThatIsValidButNotAccessible' started
Test 'Joomla\Tests\Unit\Libraries\Cms\Form\Field\AccessiblemediaFieldTest::testSetupWithValueThatIsValidButNotAccessible' ended
Test 'Joomla\Tests\Unit\Libraries\Cms\Form\Field\AccessiblemediaFieldTest::testSetupWithValueThatIsValid' started
Test 'Joomla\Tests\Unit\Libraries\Cms\Form\Field\AccessiblemediaFieldTest::testSetupWithValueThatIsValid' ended
Test 'Joomla\Tests\Unit\Libraries\Cms\Form\Field\AccessiblemediaFieldTest::testSetupWithValueThatIsNotValid' started
Test 'Joomla\Tests\Unit\Libraries\Cms\Form\Field\AccessiblemediaFieldTest::testSetupWithValueThatIsNotValid' ended
Test 'Joomla\Tests\Unit\Libraries\Cms\Form\Field\AccessiblemediaFieldTest::testSetupWithElementIsNoField' started
Test 'Joomla\Tests\Unit\Libraries\Cms\Form\Field\AccessiblemediaFieldTest::testSetupWithElementIsNoField' ended

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29440.

@wilsonge wilsonge merged commit b822535 into joomla:4.0-dev Jun 7, 2020
@wilsonge
Copy link
Contributor

wilsonge commented Jun 7, 2020

Drone seems happy. Thankyou very much!

@wilsonge wilsonge added this to the Joomla 4.0 milestone Jun 7, 2020
@astridx astridx deleted the testmedia2 branch August 9, 2020 12:27
sakiss pushed a commit to sakiss/joomla-cms that referenced this pull request Oct 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants