Skip to content

Conversation

@wilsonge
Copy link
Contributor

@wilsonge wilsonge commented May 2, 2020

Pull Request for Issue #28896 .

Summary of Changes

Fixes the ability to rename a file in media manager. This was broken in #28896 and was shows by the drone tests failing - unfortunately I still merged it anyway :)

Testing Instructions

Before patch check renaming a file with a new name gives a success message but it isn't actually renamed

Check that renaming a file to a different name works (also test that renaming a file and hitting save without saving it also works (i.e. gives a successfully renamed message).

Also check drone now passes

Documentation Changes Required

None

@dgrammatiko
Copy link
Contributor

dgrammatiko commented May 2, 2020

I think you need the newAdapter there, otherwise this is fine,

PS ignore me this is fine

@richard67
Copy link
Member

@wilsonge What means "hitting save without saving it" in the testing instructions? Or did you maybe mean "hitting save without renaming it"?

@richard67
Copy link
Member

I have tested this item ✅ successfully on b1dd3e7


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28910.

1 similar comment
@Quy
Copy link
Contributor

Quy commented May 2, 2020

I have tested this item ✅ successfully on b1dd3e7


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28910.

@Quy
Copy link
Contributor

Quy commented May 2, 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28910.

@Quy Quy removed the PR-4.0-dev label May 2, 2020
@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label May 2, 2020
@obuisard
Copy link
Contributor

obuisard commented May 2, 2020

I have tested this item ✅ successfully on b1dd3e7


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28910.

@richard67 richard67 merged commit 8e79f5b into joomla:4.0-dev May 2, 2020
@joomla-cms-bot joomla-cms-bot added PR-4.0-dev and removed RTC This Pull Request is Ready To Commit labels May 2, 2020
@richard67
Copy link
Member

Thanks to all.

@zero-24 zero-24 added this to the Joomla 4.0 milestone May 2, 2020
@wilsonge wilsonge deleted the feature/fix-media-file-rename branch May 2, 2020 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants