[4.0] Remove deprecated client handling from the updater extension adapter class#28767
Merged
wilsonge merged 2 commits intojoomla:4.0-devfrom Apr 23, 2020
Merged
[4.0] Remove deprecated client handling from the updater extension adapter class#28767wilsonge merged 2 commits intojoomla:4.0-devfrom
wilsonge merged 2 commits intojoomla:4.0-devfrom
Conversation
Quy
reviewed
Apr 22, 2020
Contributor
|
Yes it does. Thanks! |
Contributor
Author
|
This has been documented: https://docs.joomla.org/Potential_backward_compatibility_issues_in_Joomla_4#Updater |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Remove deprecated client handling from the updater extension adapter class
Testing Instructions
Expected result
the client value only accepts site and administrator and no numeric id any more
Actual result
there is still lagacy behavior in the extensionadapter class.
Documentation Changes Required
This has to be documented as B/C break.
cc @wilsonge IIRC this has to go in before beta when accepted right?