Skip to content

Comments

[4.0] Remove deprecated client handling from the updater extension adapter class#28767

Merged
wilsonge merged 2 commits intojoomla:4.0-devfrom
zero-24:zero-24-patch-1
Apr 23, 2020
Merged

[4.0] Remove deprecated client handling from the updater extension adapter class#28767
wilsonge merged 2 commits intojoomla:4.0-devfrom
zero-24:zero-24-patch-1

Conversation

@zero-24
Copy link
Contributor

@zero-24 zero-24 commented Apr 22, 2020

Summary of Changes

Remove deprecated client handling from the updater extension adapter class

Testing Instructions

  • install an outdated version of any extension
  • make sure you can update it.
  • apply this patch
  • install another outdated version on an extension
  • make sure you can stull update
  • install an outdated extension that still uses the numeric client stuff
  • confirm that now breaks as expected.

Expected result

the client value only accepts site and administrator and no numeric id any more

Actual result

there is still lagacy behavior in the extensionadapter class.

Documentation Changes Required

This has to be documented as B/C break.

cc @wilsonge IIRC this has to go in before beta when accepted right?

@wilsonge wilsonge merged commit 6316802 into joomla:4.0-dev Apr 23, 2020
@wilsonge
Copy link
Contributor

Yes it does. Thanks!

@zero-24 zero-24 deleted the zero-24-patch-1 branch April 23, 2020 11:28
@zero-24
Copy link
Contributor Author

zero-24 commented Apr 23, 2020

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants