Skip to content

Comments

[3.x] Backport Make sure the renderer does not manipulate the inline CSS and JS #28720

Closed
zero-24 wants to merge 3 commits intojoomla:stagingfrom
zero-24:backport_fix_style_script_renderer
Closed

[3.x] Backport Make sure the renderer does not manipulate the inline CSS and JS #28720
zero-24 wants to merge 3 commits intojoomla:stagingfrom
zero-24:backport_fix_style_script_renderer

Conversation

@zero-24
Copy link
Contributor

@zero-24 zero-24 commented Apr 18, 2020

Pull Request for Issue #28719

Summary of Changes

Backports the changes from #28719 to 3.x

Testing Instructions

make sure the inline css and inline js still works as exptected.

Expected result

the renderer does not manipulate the inline css and JS

Actual result

the renderer does manipulate the inline css and JS that make CSP hashbased whitelisting not possible.

Documentation Changes Required

none

@viocassel
Copy link
Contributor

I have tested this item ✅ successfully on 1e51b54


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28720.

@richard67 richard67 changed the title [3.x] Backport Make sure there rendere does not manipulate the inline CSS and JS [3.x] Backport Make sure there renderer does not manipulate the inline CSS and JS Apr 18, 2020
@richard67 richard67 changed the title [3.x] Backport Make sure there renderer does not manipulate the inline CSS and JS [3.x] Backport Make sure the renderer does not manipulate the inline CSS and JS Apr 18, 2020
@wilsonge
Copy link
Contributor

@zero-24 i think in this case i do wanna see what happens in an xhtml template. these were actually a thing at the start of Joomla 3. And in J4 i can kinda justify if that breaks and we can fix but not sure it's an option for j3

@zero-24
Copy link
Contributor Author

zero-24 commented Aug 11, 2020

Do you have a xhtml template? I don't touch the dedicated xhtml supported mention in the comments to be sure.

@zero-24
Copy link
Contributor Author

zero-24 commented Aug 25, 2020

Any update here @wilsonge ? Right now this PR does not touch the xhtml code and just the none xhtml places so this should be fine to be backported from the 4.x PR

@wilsonge
Copy link
Contributor

wilsonge commented Jan 3, 2021

I don't have one :( all the templates I'm using are HTML5. If you're confident just merge it

@HLeithner
Copy link
Member

@zero-24 I would move this to 3.10 since people using csp with hashes would break there site or I'm wrong?

@zero-24
Copy link
Contributor Author

zero-24 commented Jan 3, 2021

Well why? You can already have a site that use hashes in 3.x. well not autgenerated right now as the renderer is broken..

@HLeithner
Copy link
Member

HLeithner commented Jan 3, 2021

can I add the hash to the renderer now? I didn't looked at it it's only something come into my mind

Edit: ok can't be added to this function so looks ok

@zero-24 zero-24 closed this Apr 7, 2021
@zero-24 zero-24 deleted the backport_fix_style_script_renderer branch April 7, 2021 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants