Skip to content

[4.0][Atum] Some searchtool fixes#28644

Merged
wilsonge merged 2 commits intojoomla:4.0-devfrom
ciar4n:menu-tools
Apr 11, 2020
Merged

[4.0][Atum] Some searchtool fixes#28644
wilsonge merged 2 commits intojoomla:4.0-devfrom
ciar4n:menu-tools

Conversation

@ciar4n
Copy link
Contributor

@ciar4n ciar4n commented Apr 11, 2020

Pull Request for Issue #28615 (comment) .

Summary of Changes

Fixes some layout issues on com_menu and com_assosiations.

Testing Instructions

Apply this patch and run node build.js --compile-css for updating the changed SCSS. Check searchtools are displaying correctly.

@infograf768

@Razzo1987
Copy link
Contributor

Razzo1987 commented Apr 11, 2020

I have tested this item ✅ successfully on dff34bc

Yes, now is inline
immagine


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28644.

@richard67
Copy link
Member

@ciar4n The clear button still has same color as the filter options button when a filter is applied. Was the 2nd thing which @infograf768 remarked in his comment in the other PR. Should that be fixed here, too? The inline display of the filter options is ok now, as the previlus tester remarked.

@adj9
Copy link

adj9 commented Apr 11, 2020

I have tested this item ✅ successfully on dff34bc

with the patch I have the voices horizontally.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28644.

@ciar4n
Copy link
Contributor Author

ciar4n commented Apr 11, 2020

@richard67 Thx. Yes that can be added here. Color added to clear button with 1700a92

image

@richard67
Copy link
Member

Will test in a few minutes. @Razzo1987 Could you test again? This time not only if the search filter drop downs are properly inlined but also if the color of the "Clear" button for the filter is like shown in the previous comment? Thanks in advance.

@richard67
Copy link
Member

I have tested this item ✅ successfully on 1700a92

Both of the issue mentioned in #28615 (comment) are fixed now.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28644.

@alikon
Copy link
Contributor

alikon commented Apr 11, 2020

I have tested this item ✅ successfully on 1700a92


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28644.

@alikon
Copy link
Contributor

alikon commented Apr 11, 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28644.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Apr 11, 2020
@wilsonge wilsonge merged commit 179f056 into joomla:4.0-dev Apr 11, 2020
@wilsonge
Copy link
Contributor

Thanks!

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Apr 11, 2020
@wilsonge wilsonge added this to the Joomla 4.0 milestone Apr 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants