Skip to content

Conversation

@richard67
Copy link
Member

Pull Request for Issue #28425 (comment).

Summary of Changes

Same as in PR #28425 but for the component-specific install sql.

This is not really used anymore but still shall be kept up-to-date according to @wilsonge 's comment here: #28425 (comment).

For PostgreSQL only comments and code style have changed so it is more equal to the corresponding section in the joomla.sql file.

Testing Instructions

Code review:

  • Compare the mysql/joomla.sql and the install.mysql.sql files and verify that beside comments and empty lines, the sections for creating com_finder tables in both files are the same.
  • Compare the postgresql/joomla.sql and the install.postgresql.sql files and verify that beside comments and empty lines, the sections for creating com_finder tables in both files are the same.
  • Verify that the changes in the install.XXX.sql files are basically the same as done in PR [4.0] Change collations of com_finder tables from general to unicode on MySQL databases. #28425 in the corresponding joomla.sql file.

Expected result

Files install.mysql.sql and install.postgresql.sql of com_finder are up-to-date with the changes in PR #28425 for joomla.sql.

Actual result

Files install.mysql.sql and install.postgresql.sql of com_finder are not up-to-date with the changes in PR #28425 for joomla.sql.

Documentation Changes Required

None.

@wilsonge
Copy link
Contributor

Thanks!

@wilsonge wilsonge added this to the Joomla 4.0 milestone Mar 25, 2020
@richard67 richard67 deleted the 4.0-dev-finder-install-sql-unicode-collations branch March 25, 2020 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants