Skip to content

Comments

[4.0] WebAsset for layouts#28431

Merged
wilsonge merged 8 commits intojoomla:4.0-devfrom
Fedik:asset-layouts
Apr 5, 2020
Merged

[4.0] WebAsset for layouts#28431
wilsonge merged 8 commits intojoomla:4.0-devfrom
Fedik:asset-layouts

Conversation

@Fedik
Copy link
Member

@Fedik Fedik commented Mar 22, 2020

Summary of Changes

This replaces htmlhelper to webaset for layouts

Updated layouts:

joomla/html/batch/item
joomla/html/batch/language
joomla/html/batch/adminlanguage
joomla/form/field/calendar
joomla/form/field/color/slider
joomla/form/field/password
joomla/form/renderfield
joomla/toolbar/containeropen
joomla/searchtools/default/filters
joomla/edit/frontediting_modules
joomla/content/options_default
plugins/system/webauthn/manage

Testing Instructions

Apply patch. Run npm install
Click around, check calendar, template style colors, batch, fields "showon",
all should work as before

Expected result

All work

Actual result

All work

Documentation Changes Required

nope

ref #22435

@joomla-cms-bot joomla-cms-bot added NPM Resource Changed This Pull Request can't be tested by Patchtester PR-4.0-dev labels Mar 22, 2020
 Conflicts:
	build/media_source/legacy/joomla.asset.json
 Conflicts:
	build/media_source/system/joomla.asset.json
@alikon
Copy link
Contributor

alikon commented Apr 4, 2020

I have tested this item ✅ successfully on ff7a94f

tested with the new patchtester 4
so i'vent runned npm install


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28431.

@Fedik
Copy link
Member Author

Fedik commented Apr 5, 2020

I have added all "showon" cases to this PR, to make "showon" use WebAsset in all places,
this now fully cover #28456

@wilsonge wilsonge merged commit 2b2161a into joomla:4.0-dev Apr 5, 2020
@wilsonge
Copy link
Contributor

wilsonge commented Apr 5, 2020

LGTM! Thanks!

@wilsonge wilsonge added this to the Joomla 4.0 milestone Apr 5, 2020
@Fedik Fedik deleted the asset-layouts branch April 5, 2020 14:03
@bugsmafia
Copy link

This began to cause a drop wherever the password field is involved.

An error has occurred.
0 There is no "field.passwordview" asset of a "script" type in the registry.
iYUFsjZDTUmveTa7WhpYUQ 1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

NPM Resource Changed This Pull Request can't be tested by Patchtester

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants