Merged
Conversation
|
I have tested this item ✅ successfully on 7619bb8 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28396. |
|
I have tested this patch successfully. Thank you!!! This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28396. |
|
I have tested this item ✅ successfully on 7619bb8 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28396. |
Contributor
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28396. |
Member
|
Can the wording « diff » be modified to « differences » ? |
Contributor
Author
|
Yes, but I like the shorter form. What do others say? |
|
I think it might look better "differences" |
Contributor
Author
|
OK, done. |
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
At the moment you can not see in the template manager what function the Switches have. It looks like this to me.
I have also corrected the alignment. For
ltrit was only needed to remove a margin. The alignment is OK. ForrtlI added the correct alignment.The label is not inserted. We would have to use
echo $this→form→renderField('show_core');for this.
I tried to display the label. However, it is difficult to position the switcher with label correctly at this point. Therefore I think it is good to only display the
inputand to adapt the description text.Testing Instructions
Create an override in the Template Manager and open it for editing. You see two switches. You don't know what these switches do.
Apply this patch
Switch back to the template manager and see that the description text of the switches now shows the current status. You now know what switch is responsible for.
Expected result
You can see the function that a switch performs based on the label or description.
Actual result
You see switches but you do not know what the switch
hideorshow.Additional information
Because of
joomla-cms/administrator/templates/atum/scss/template-rtl.scss
Line 209 in 9f68e6e
This is a redo of parts of this PR: #26359