Skip to content

[4.0] Override-Manager fix#28396

Merged
wilsonge merged 2 commits intojoomla:4.0-devfrom
astridx:overridemanager
Mar 20, 2020
Merged

[4.0] Override-Manager fix#28396
wilsonge merged 2 commits intojoomla:4.0-devfrom
astridx:overridemanager

Conversation

@astridx
Copy link
Contributor

@astridx astridx commented Mar 19, 2020

Summary of Changes

At the moment you can not see in the template manager what function the Switches have. It looks like this to me.

Templates  Customise  Cassiopeia    test   Administration(3)

I have also corrected the alignment. For ltr it was only needed to remove a margin. The alignment is OK. For rtl I added the correct alignment.

The label is not inserted. We would have to use
echo $this→form→renderField('show_core');
for this.

I tried to display the label. However, it is difficult to position the switcher with label correctly at this point. Therefore I think it is good to only display the input and to adapt the description text.

Testing Instructions

  1. Create an override in the Template Manager and open it for editing. You see two switches. You don't know what these switches do.

  2. Apply this patch

  3. Switch back to the template manager and see that the description text of the switches now shows the current status. You now know what switch is responsible for.

Expected result

You can see the function that a switch performs based on the label or description.

قالب ها  اختصاصی سازی قالب  Cassiopeia    test   مدیریت

Templates  Customise  Cassiopeia    test   Administration(2)

Actual result

You see switches but you do not know what the switch hide or show.

Additional information

Because of

we need the change in the CSS-file.

This is a redo of parts of this PR: #26359

@joomla-cms-bot joomla-cms-bot added Language Change This is for Translators NPM Resource Changed This Pull Request can't be tested by Patchtester PR-4.0-dev labels Mar 19, 2020
@astridx astridx changed the title overridemanager [4.0] Override-Manager fix Mar 19, 2020
@carcam
Copy link

carcam commented Mar 19, 2020

I have tested this item ✅ successfully on 7619bb8

I have successfully tested this patch ;) Thank you!!


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28396.

@maikol-ortigueira
Copy link

I have tested this patch successfully. Thank you!!!
screen shot 2020-03-19 at 16 42 00


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28396.

@maikol-ortigueira
Copy link

I have tested this item ✅ successfully on 7619bb8

Tested successfully, thank you!!


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28396.

@joomla-cms-bot joomla-cms-bot removed Language Change This is for Translators NPM Resource Changed This Pull Request can't be tested by Patchtester PR-4.0-dev labels Mar 19, 2020
@Quy
Copy link
Contributor

Quy commented Mar 19, 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28396.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Mar 19, 2020
@infograf768
Copy link
Member

Can the wording « diff » be modified to « differences » ?

@astridx
Copy link
Contributor Author

astridx commented Mar 19, 2020

Yes, but I like the shorter form. What do others say?

@maikol-ortigueira
Copy link

I think it might look better "differences"

@joomla-cms-bot joomla-cms-bot added Language Change This is for Translators NPM Resource Changed This Pull Request can't be tested by Patchtester PR-4.0-dev labels Mar 19, 2020
@astridx
Copy link
Contributor Author

astridx commented Mar 19, 2020

OK, done.

@wilsonge wilsonge merged commit ebcda05 into joomla:4.0-dev Mar 20, 2020
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Mar 20, 2020
@wilsonge
Copy link
Contributor

Thanks!

@wilsonge wilsonge added this to the Joomla 4.0 milestone Mar 20, 2020
@astridx astridx deleted the overridemanager branch August 9, 2020 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Language Change This is for Translators NPM Resource Changed This Pull Request can't be tested by Patchtester

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants