[4.0] Update UCM content types#28364
Merged
wilsonge merged 9 commits intojoomla:4.0-devfrom Apr 7, 2020
SharkyKZ:j4/ucm-content-types
Merged
[4.0] Update UCM content types#28364wilsonge merged 9 commits intojoomla:4.0-devfrom SharkyKZ:j4/ucm-content-types
wilsonge merged 9 commits intojoomla:4.0-devfrom
SharkyKZ:j4/ucm-content-types
Conversation
added 7 commits
March 13, 2020 10:11
Contributor
Aim is to move component specific classes out of the common library tables. They were originally there because getting them out of components wasn't easy/obvious. Now that we the |
Contributor
|
If you can fix conflicts here will try and get this merged |
Contributor
Author
|
Conflicts solved. |
Contributor
|
Thanks! |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Followup to #27992.
Summary of Changes
Updates remaining
#__content_typesentries with fully qualified class names.Note, this also changes article table from
Joomla\CMS\Table\ContenttoJoomla\Component\Content\Administrator\Table\ArticleTable. I'm actually not sure if this is needed or not, or why this class was added to 4.0 in the first place. Need feedback on this.Testing Instructions
This will need to be tested both for new installations and for upgrades from 3.10. Not sure how to test upgrades - the code doesn't seem to be executed when updating from 3.10-dev?
Create and edit some categories for different content types.
Create and edit some articles.
In edit form click Versions button. Check that current item version is marked with a star.
Documentation Changes Required
No.