Skip to content

[4.0] Update UCM content types#28364

Merged
wilsonge merged 9 commits intojoomla:4.0-devfrom
SharkyKZ:j4/ucm-content-types
Apr 7, 2020
Merged

[4.0] Update UCM content types#28364
wilsonge merged 9 commits intojoomla:4.0-devfrom
SharkyKZ:j4/ucm-content-types

Conversation

@SharkyKZ
Copy link
Contributor

Followup to #27992.

Summary of Changes

Updates remaining #__content_types entries with fully qualified class names.

Note, this also changes article table from Joomla\CMS\Table\Content to Joomla\Component\Content\Administrator\Table\ArticleTable. I'm actually not sure if this is needed or not, or why this class was added to 4.0 in the first place. Need feedback on this.

Testing Instructions

This will need to be tested both for new installations and for upgrades from 3.10. Not sure how to test upgrades - the code doesn't seem to be executed when updating from 3.10-dev?

Create and edit some categories for different content types.
Create and edit some articles.
In edit form click Versions button. Check that current item version is marked with a star.

Documentation Changes Required

No.

@wilsonge
Copy link
Contributor

wilsonge commented Apr 7, 2020

Note, this also changes article table from Joomla\CMS\Table\Content to Joomla\Component\Content\Administrator\Table\ArticleTable. I'm actually not sure if this is needed or not, or why this class was added to 4.0 in the first place. Need feedback on this.

Aim is to move component specific classes out of the common library tables. They were originally there because getting them out of components wasn't easy/obvious. Now that we the MVCFactories within components - this is much easier than previously and it makes more sense to use them rather than have them in central libraries structure.

@wilsonge
Copy link
Contributor

wilsonge commented Apr 7, 2020

If you can fix conflicts here will try and get this merged

@SharkyKZ
Copy link
Contributor Author

SharkyKZ commented Apr 7, 2020

Conflicts solved.

@wilsonge wilsonge merged commit bf2cfd0 into joomla:4.0-dev Apr 7, 2020
@wilsonge
Copy link
Contributor

wilsonge commented Apr 7, 2020

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants