Skip to content

[4.0] Fixing searchtools in xtd plugins in frontend (partial fix)#28248

Merged
wilsonge merged 1 commit intojoomla:4.0-devfrom
infograf768:4.0_frontend_xtds
Mar 9, 2020
Merged

[4.0] Fixing searchtools in xtd plugins in frontend (partial fix)#28248
wilsonge merged 1 commit intojoomla:4.0-devfrom
infograf768:4.0_frontend_xtds

Conversation

@infograf768
Copy link
Member

Pull Request for Issue #28119

Summary of Changes

This PR adds searchtools to frontend cassiopea in order to display correctly and use the filters (Filter Options, Clean) when using XTD plugins when editing an article.

It solves correctly the Contact XTD as well as Menu XTD
It also solves tooltips in the search field.

It does NOT solve entirely the issue for Article filters as well as Module filters
This would need a PR by another volunteer to deal with these fields.

Testing Instructions

Edit an article in frontend and use the various XTDs. Try to display or not filters, etc.

Before patch

Screen Shot 2020-03-06 at 10 46 26

Screen Shot 2020-03-06 at 10 46 11

Screen Shot 2020-03-06 at 10 45 50

Screen Shot 2020-03-06 at 10 45 25

After patch

Screen Shot 2020-03-06 at 10 42 19_after

Screen Shot 2020-03-06 at 10 41 59

Screen Shot 2020-03-06 at 10 41 11

Screen Shot 2020-03-06 at 10 40 54

Note

I may have added more variables than necessary as well as svg. This can be solved after a next PR which would entirely correct the Article and Module filter fields

@richard67
Copy link
Member

I have tested this item ✅ successfully on a5898e5


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28248.

1 similar comment
@alikon
Copy link
Contributor

alikon commented Mar 8, 2020

I have tested this item ✅ successfully on a5898e5


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28248.

@joomla-cms-bot joomla-cms-bot removed Language Change This is for Translators PR-4.0-dev labels Mar 8, 2020
@alikon
Copy link
Contributor

alikon commented Mar 8, 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28248.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Mar 8, 2020
@infograf768
Copy link
Member Author

I also at last found the reason of the broken fields in XTD module frontend.
xml is wrong
patch would be

diff --git a/components/com_modules/forms/filter_modules.xml b/components/com_modules/forms/filter_modules.xml
index 37df5bb..4e0e9bb 100644
--- a/components/com_modules/forms/filter_modules.xml
+++ b/components/com_modules/forms/filter_modules.xml
@@ -1,6 +1,4 @@
 <?xml version="1.0" encoding="utf-8"?>
-<form>
-	<fieldset addfieldpath="/administrator/components/com_modules/models/fields" />
-
+<form addfieldprefix="Joomla\Component\Modules\Administrator\Field">

As soon as this PR is merged, will make a specific PR for that.

@alikon alikon removed the RTC This Pull Request is Ready To Commit label Mar 8, 2020
@infograf768
Copy link
Member Author

don't know why it was changed. RTC again


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28248.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Mar 9, 2020
@infograf768
Copy link
Member Author

Note: Changes to filter_articles.xml (frontend) will correct the display of the fields concerned. In next PR.

This does not mean ALL css is corrected/improved (including RTL), but it lets work on these for cassiopea.

@infograf768
Copy link
Member Author

@wilsonge
Please let's get this in to be able to work further.

@alikon
Copy link
Contributor

alikon commented Mar 9, 2020

don't know why it was changed. RTC again

cause i missed your last sentence

As soon as this PR is merged, will make a specific PR for that.

@wilsonge wilsonge merged commit 801b8ea into joomla:4.0-dev Mar 9, 2020
@wilsonge
Copy link
Contributor

wilsonge commented Mar 9, 2020

Thanks!

@joomla-cms-bot joomla-cms-bot added Language Change This is for Translators PR-4.0-dev and removed RTC This Pull Request is Ready To Commit labels Mar 9, 2020
@wilsonge wilsonge added this to the Joomla 4.0 milestone Mar 9, 2020
@infograf768 infograf768 deleted the 4.0_frontend_xtds branch March 9, 2020 09:53
@infograf768
Copy link
Member Author

@alikon @richard67
First PR ready to test
#28283

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Language Change This is for Translators

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants