Fix some issues when saving menus #28053
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #27828 and #26947.
Summary of Changes
Append ID to redirect URL so it doesn't get lost.
Clear session data when applying changes to load data from database.
Testing Instructions
Create two menus (menu1 and menu2).
Edit menu2.
Change its Menu Type to menu1.
Click Save.
After saving fails, change its menu type to menu3 and save.
View menus.
Edit a menu.
Remove its menu type.
Use browser tools to circumvent JS validation (remove
requiredclass and attribute from menu type field).Click Save.
After saving fails, edit menu type back to what it was.
Save.
Expected result
Actual result
Save failed with the following error: Menu type exists:...Documentation Changes Required
No.