Skip to content

Conversation

@SharkyKZ
Copy link
Contributor

@SharkyKZ SharkyKZ commented Feb 24, 2020

Fixes #27828 and #26947.

Summary of Changes

Append ID to redirect URL so it doesn't get lost.
Clear session data when applying changes to load data from database.

Testing Instructions

Create two menus (menu1 and menu2).
Edit menu2.
Change its Menu Type to menu1.
Click Save.
After saving fails, change its menu type to menu3 and save.
View menus.

Edit a menu.
Remove its menu type.
Use browser tools to circumvent JS validation (remove required class and attribute from menu type field).
Click Save.
After saving fails, edit menu type back to what it was.
Save.

Expected result

  1. menu2 type changed to menu3.
  2. Menu saved.

Actual result

  1. A new menu with type menu3 is created.
  2. Saving fails with error: Save failed with the following error: Menu type exists:...

Documentation Changes Required

No.

@joomdonation
Copy link
Contributor

I have tested this item ✅ successfully on 1a681df


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28053.

1 similar comment
@infograf768
Copy link
Member

I have tested this item ✅ successfully on 1a681df


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28053.

@infograf768
Copy link
Member

rtc


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28053.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Feb 25, 2020
@Quy Quy added the PR-staging label Feb 25, 2020
@rdeutz rdeutz merged commit b030efc into joomla:staging Feb 25, 2020
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Feb 25, 2020
@rdeutz rdeutz added this to the Joomla! 3.9.16 milestone Feb 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

behaviour when error on type of menu

6 participants