Skip to content

Conversation

@infograf768
Copy link
Member

Summary of Changes

Adding missing string in case a content language can't be created when installing a language during J installation

Saw this when testing #25258 (comment) on a clean install.

Issue will normally be solved by #27854 but better be safe in case a Content Language can't be created at J installation time.

@richard67

@joomla-cms-bot joomla-cms-bot added Language Change This is for Translators PR-4.0-dev labels Feb 9, 2020
@richard67
Copy link
Member

@infograf768 I haven't seen that warning, not translated and not untranslated, and this PR here seems to deal with new installation. Shall we do real test or do code review only? Please provide instructions.

@richard67
Copy link
Member

@infograf768 Forget my previous question. Got it. Am just testing.

@richard67
Copy link
Member

richard67 commented Feb 9, 2020

I have tested this item ✅ successfully on e946049

On a clean current 4.0-dev branch as long as PR #27854 hasn't been merged yet, make a new installation.
At the end of installation, customize installation and install e.g. Persian language.
Result: Notice alert shown.
Without PR notice not translated but showing the language string constant.
pr-27870_1

With this PR: OK, correct message is shown.
pr-27870_2


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27870.

@infograf768
Copy link
Member Author

This new string is just a precaution. There are many possible reasons why a content language could not be created.

@wilsonge wilsonge merged commit b613e97 into joomla:4.0-dev Feb 9, 2020
@wilsonge
Copy link
Contributor

wilsonge commented Feb 9, 2020

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Language Change This is for Translators

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants