[4.0] Remove negative margin in tinymce builder#27862
Merged
Quy merged 1 commit intojoomla:4.0-devfrom Feb 9, 2020
Merged
Conversation
joomla-cms-bot
added
NPM Resource Changed
bembelimen
changed the title
Member
|
yeah, that was changed in #27684 |
Member
|
I have tested this item ✅ successfully on 723fb1a This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27862. |
1 similar comment
Member
|
I have tested this item ✅ successfully on 723fb1a This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27862. |
richard67
removed
NPM Resource Changed
Member
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27862. |
richard67
added
NPM Resource Changed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Revert #27466
Currently
After patch + npm
Testing Instructions
Open the TinyMCE plugin and check the position of the elements.
Expected result
Everything aligned
Actual result
Everything is left outside
@brianteeman could you please check, because you added the margin for a reason. Perhaps my settings are wrong (latest Firefox)