Conversation
This PR ensures that the position of the colorpicker is positioned correctly by increasing the specificity of the css AND making sure it is actually imported. It also ensures that the pointer is used and not the I-beam PR for joomla#27538 npm -i as it is a css change
joomla-cms-bot
added
NPM Resource Changed
|
The CSS file is already being loaded here: https://github.com/joomla/joomla-cms/blob/4.0-dev/layouts/joomla/form/field/color/advanced.php#L76 |
|
thats the vendor supplied css not the override |
|
ah my bad |
| @import "blocks/global"; // Leave this first | ||
|
|
||
| // jQuery Minicolors | ||
| @import "../../../../build/media_source/system/scss/jquery-minicolors"; |
There was a problem hiding this comment.
This is wrong! There is already a css file so either override it or extend it. The template shouldn't be aware of every 3rd pd extension that might be used in some pages, Joomla has specific layouts for these (input colour advanced for this one iirc)...
There was a problem hiding this comment.
So why is the file there and why is it used in Cassiopeia?
Getting really sick of you telling everyone they are wrong without contributing. You're starting to be a troll.
There was a problem hiding this comment.
Getting really sick of you telling everyone they are wrong without contributing
This is funny I did #26077 so people can follow up and fix the rest and now you're undoing it instead of fixing whatever bug. Do you expect me to fix this ugly spaghetti of css alone?
So why is the file there and why is it used in Cassiopeia?
If it's embedded in the template's css then it's wrong. Joomla is modularised by default making it a freaking monolith is wrong, but hey it's working.
There was a problem hiding this comment.
I guess you missed the fact that this PR was to fix an issue raised by someone with far more experience than me at scss.
I guess you missed the fact that I specifically asked where to put the code and the same person with far more experience than me at scss told me where to put it. Which is exactly what I did.
There was a problem hiding this comment.
Whoever told you to put the css there IS WRONG. Joomla by default is modular, with this kind of code snippets you're making it monolith. Prove me wrong!
There was a problem hiding this comment.
To be quite clear here: I'm arguing with this approach because you're effectively undoing #26077
|
I have tested this item ✅ successfully on 947d88d This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27829. |
joomla-cms-bot
removed
NPM Resource Changed
|
I have tested this item ✅ successfully on 947d88d This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27829. |
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27829. |
richard67
added
NPM Resource Changed
|
@richard67 RTC? Really??? Did you ready any of my comments? |
|
@dgrammatiko Yes I did read them but I'm not deep enough into these things to tell what is right and what is wrong. I only can see this PR solves an issue. @wilsonge Should I revert the RTC until the discussion is clarified? |
|
@C-Lodder What's your opinion? |
|
This will do. It can be followed up with a vendor specific override in a future PR |
|
thanks <200 now |
7 participants
This PR ensures that the position of the colorpicker is positioned correctly by increasing the specificity of the css AND making sure it is actually imported. It also ensures that the pointer is used and not the I-beam
PR for #27538
npm -i as it is a css change
Further details in the report #27538