Skip to content

Conversation

@astridx
Copy link
Contributor

@astridx astridx commented Feb 2, 2020

Pull Request for Issue #27772

Should I close the issue #27772 ? I am not sure whether changes in J4 will be adopted because the directory is now moved.

@wilsonge
Copy link
Contributor

wilsonge commented Feb 2, 2020

The changes will get ported from here anyhow :) it’s just a bit of extra work on my end

@toivo
Copy link
Contributor

toivo commented Feb 4, 2020

I have tested this item ✅ successfully on 82c10b4

Tested in 3.9.15 and PHP 7.4.2 on localhost


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27775.

@Quy
Copy link
Contributor

Quy commented Feb 4, 2020

I have tested this item ✅ successfully on 82c10b4


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27775.

@Quy Quy removed the PR-staging label Feb 4, 2020
@Quy
Copy link
Contributor

Quy commented Feb 4, 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27775.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Feb 4, 2020
@astridx
Copy link
Contributor Author

astridx commented Feb 4, 2020

I honestly don't know what the import jimport('joomla.html.html.bootstrap'); is for.

Since the file /libraries/src/HTML/HTML/Bootstrap does not exist, I dare to delete this line, as asked here.

@brianteeman
Copy link
Contributor

that line originates from #29072 - you can find out why it existed there

@astridx
Copy link
Contributor Author

astridx commented Feb 4, 2020

Thank you @brianteeman But, what is #29072? Currently our highest number is #27805.

@brianteeman
Copy link
Contributor

Sorry thats an old joomlacode reference number
https://developer.joomla.org/joomlacode-archive/issue-29072.html

@rdeutz rdeutz merged commit 20730e6 into joomla:staging Feb 5, 2020
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Feb 5, 2020
@rdeutz rdeutz added this to the Joomla! 3.9.16 milestone Feb 6, 2020
@astridx astridx deleted the 3xcontactdefault branch August 9, 2020 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants