[4.0] RTL: correcting Joomla Installation display#27732
[4.0] RTL: correcting Joomla Installation display#27732wilsonge merged 5 commits intojoomla:4.0-devfrom
Conversation
|
Not sure about that. After patch has still a language which per se is ltr, also users which a rtl language will see and read it ltr. This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27732. |
This has been corrected by @wilsonge recently. It now behaves correctly as in J3. |
5056eab to
fcc6d87
Compare
|
@Quy |
|
I have tested this item ✅ successfully on 47cf8b2 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27732. |
1 similar comment
|
I have tested this item ✅ successfully on 47cf8b2 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27732. |
|
@infograf768 PR does what it claims to do, so I give it a good test. But I saw that when editing the database prefix field and the browser offers a previously used value, the offered value is left aligned: With other text fields this is not the case: Do you think you can fix that, too? |
|
That value is set to be LTR and align right when using an RTL language, in order to get the underscore correctly. I remarked that the field "remembers" former prefixes used. I.e. when we click in the field when it is empty, you can choose one of the prefixes in the list. The fact that this specific field is set as LTR forces the dropdown to display it as LTR. The text-align is not considered by the browser. Therefore I guess nothing we can do about that and if you chose one of the existing values it will display correctly in the field and saved correctly. |
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27732. |
|
Getting this in so we largely have a working RTL installer. If anyone has ideas on specifics for that dropdown willing to consider any further PRs obviously |
|
It is always going to be "strange" when you use an ltr text in a RTL site. |
|
@infograf768 Sorry for late answer, but I needed my beauty sleep ;-) I thought that drow down is a standard Firefox thing, am using the latest version. But meanwhile I'm not so sure, maybe it is also coming from my F-Secure addon. It shows that drop down as soon as you type something in that field which fits to what was remembered for that field from previous usage. E.g. if for username field was "richard" in past, it shows the dropdown when you are starting to type "rich". For me this is not really an issue. |
|
@infograf768 P.S.: Your explanation above explains it well and is absolue ok for me. |
|
@richard67 |






Summary of Changes
Correcting Select language height by taking off
custom-select-sm(this also for LTR) and using the correctselect-bg-rtl.svgfor RTL by adding the file.Correcting placement of top icon
Correcting Install Languages caption text alignement
Deleted unused
select-bg-active.svgTesting Instructions
Patch. Run npm.
Edit en-GB langmetadata.xml to set RTL to 1
Before patch
LTR
RTL

After patch
RTL Top icon correct placement
Select language OK (height also OK for LTR )
RTL Caption (text-align was set to left)
Documentation Changes Required