Skip to content

[4.0] Correct database connection encryption fields order in the installation form#27727

Merged
Quy merged 3 commits intojoomla:4.0-devfrom
richard67:40-dev-installer-correct-db-encryption-fields-order
Jan 31, 2020
Merged

[4.0] Correct database connection encryption fields order in the installation form#27727
Quy merged 3 commits intojoomla:4.0-devfrom
richard67:40-dev-installer-correct-db-encryption-fields-order

Conversation

@richard67
Copy link
Member

@richard67 richard67 commented Jan 30, 2020

Pull Request for new issue.

Summary of Changes

This Pull Request (PR) corrects the ordering of the fields for database connection encryption options in the installation form so it is the same as in the server tab of global configuration in backend when value"Two-way authentication" is selected in drop down "Connection Encryption". For the other values "Default (server controlled)" and "One-way authentication" of this drop down ordering is already ok.

The reason for the wrong ordering is a mistake I've made in my PR #27348 .

The form xml file https://github.com/joomla/joomla-cms/blob/4.0-dev/installation/forms/setup.xml already has the right ordering, but the installation form doesn't use the xml to create the fields.

Testing Instructions

  1. On an installed 4.0-dev or recent nightly build, login to backend and go to the "Server" tab of "Global Configuration".
  2. Select option "Two-way authentication" in the drop down "Connection Encryption".
  3. Note the order of the fields for database encryption e.g. by making a screenshot.
  4. Set the switcher "Server Certificate Verification" to "Yes".
  5. Note again the order of the fields for database encryption e.g. by making a screenshot.
  6. Start a new installation of the same 4.0-dev code or nightly build package on another server, or use the same server and delete configuration.php before starting the installation.
  7. When coming to the databae connection options, select option "Two-way authentication" in the drop down "Connection Encryption".
  8. Note the order of the fields for database encryption e.g. by making a screenshot.
  9. Set the switcher "Server Certificate Verification" to "Yes".
  10. Note again the order of the fields for database encryption e.g. by making a screenshot.
  11. Compare the results from global configuration and the installation form.
    Result: See section "Actual result" below.
  12. Apply this PR.
  13. Repeat steps 6 to 11.
    Result: See section "Expected result" below.

Expected result

The ordering of fields for database connection encryption options is the same as in global configuration in backend.

  • 2-way authentication without server certificate verification:
    db-ssl-options_install_2-way-no-verify_corrected
  • 2-way authentication with server certificate verification:
    db-ssl-options_install_2-way-verify_corrected

Actual result

  • 2-way authentication without server certificate verification:
    db-ssl-options_install_2-way-no-verify
  • 2-way authentication with server certificate verification:
    db-ssl-options_install_2-way-verify

Documentation Changes Required

No. Help screens for installation form have to be updated anyway.

@Quy
Copy link
Contributor

Quy commented Jan 30, 2020

I have tested this item ✅ successfully on fa252d3


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27727.

1 similar comment
@SharkyKZ
Copy link
Contributor

I have tested this item ✅ successfully on fa252d3


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27727.

@SharkyKZ
Copy link
Contributor

RTC.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27727.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jan 30, 2020
@richard67
Copy link
Member Author

Thanks for testing.

@Quy Quy merged commit aae5b3b into joomla:4.0-dev Jan 31, 2020
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Jan 31, 2020
@Quy Quy added this to the Joomla 4.0 milestone Jan 31, 2020
@richard67 richard67 deleted the 40-dev-installer-correct-db-encryption-fields-order branch January 31, 2020 16:35
@richard67
Copy link
Member Author

Thanks.

brianteeman pushed a commit to brianteeman/joomla-cms that referenced this pull request Feb 4, 2020
Co-authored-by: Quy <quy@fluxbb.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants