[4.0] Correct database connection encryption fields order in the installation form#27727
Merged
Quy merged 3 commits intojoomla:4.0-devfrom Jan 31, 2020
Conversation
Contributor
|
I have tested this item ✅ successfully on fa252d3 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27727. |
1 similar comment
Contributor
|
I have tested this item ✅ successfully on fa252d3 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27727. |
Contributor
|
RTC. This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27727. |
Member
Author
|
Thanks for testing. |
Member
Author
|
Thanks. |
brianteeman
pushed a commit
to brianteeman/joomla-cms
that referenced
this pull request
Feb 4, 2020
Co-authored-by: Quy <quy@fluxbb.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request for new issue.
Summary of Changes
This Pull Request (PR) corrects the ordering of the fields for database connection encryption options in the installation form so it is the same as in the server tab of global configuration in backend when value"Two-way authentication" is selected in drop down "Connection Encryption". For the other values "Default (server controlled)" and "One-way authentication" of this drop down ordering is already ok.
The reason for the wrong ordering is a mistake I've made in my PR #27348 .
The form xml file https://github.com/joomla/joomla-cms/blob/4.0-dev/installation/forms/setup.xml already has the right ordering, but the installation form doesn't use the xml to create the fields.
Testing Instructions
Result: See section "Actual result" below.
Result: See section "Expected result" below.
Expected result
The ordering of fields for database connection encryption options is the same as in global configuration in backend.
Actual result
Documentation Changes Required
No. Help screens for installation form have to be updated anyway.