Skip to content

Conversation

@Fedik
Copy link
Member

@Fedik Fedik commented Jan 18, 2020

Summary of Changes

This fix a bug, when the params tab become empty if one of the field is a subform with own fieldset

Testing Instructions

Apply patch.
Add next subform field to Custom HTML module (in <fieldset name="options"):

<field name="test_fields" type="subform" label="test_fields"
  filter="FooBar::filterTest" multiple="true" min="1" groupByFieldset="true">
   <form>
    <fieldset name="test1" label="fieldset 1">
     <field name="test_field" type="text" label="TESTFIELD1"/>
    </fieldset>
    <fieldset name="test2" label="fieldset 2">
     <field name="test_field2" type="text" label="TESTFIELD2"/>
    </fieldset>
   </form>
</field>

Open the module for editing, check the options tab (or where field was added)

Expected result

you see there all fields, and subform field also

Actual result

the tab are empty

@Fedik
Copy link
Member Author

Fedik commented Jan 18, 2020

@N6REJ please test

@N6REJ
Copy link
Contributor

N6REJ commented Jan 26, 2020

could not test via patchtester so applied changes manually and it works properly.

@Quy
Copy link
Contributor

Quy commented Mar 24, 2020

I have tested this item ✅ successfully on 1be3055


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27563.

@Quy
Copy link
Contributor

Quy commented Mar 24, 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27563.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Mar 24, 2020
@wilsonge wilsonge merged commit b5646da into joomla:4.0-dev Mar 24, 2020
@wilsonge
Copy link
Contributor

Thanks!

@joomla-cms-bot joomla-cms-bot added PR-4.0-dev and removed RTC This Pull Request is Ready To Commit labels Mar 24, 2020
@wilsonge wilsonge added this to the Joomla 4.0 milestone Mar 24, 2020
@Fedik Fedik deleted the subform-fieldset-fix branch March 25, 2020 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants