Skip to content

[4.0] PSR4 namespace#27464

Closed
brianteeman wants to merge 4 commits intojoomla:4.0-devfrom
brianteeman:psr4
Closed

[4.0] PSR4 namespace#27464
brianteeman wants to merge 4 commits intojoomla:4.0-devfrom
brianteeman:psr4

Conversation

@brianteeman
Copy link
Contributor

This will hopefully resolve the remaining appveyor issues

PR for #27014

I assume that if the appveyor tests complete without any deprecated notices then this is correct

cc @wilsonge

This will hopefully resolve the remaining appveyor issues

PR for joomla#27014

I assume that if the appveyor tests complete without any deprecated notices then this is correct

cc @wilsonge
@brianteeman
Copy link
Contributor Author

@wilsonge all the appveyor deprecated notices have gone - no idea about anything else in thi8s PR so its up to you

@SharkyKZ
Copy link
Contributor

SharkyKZ commented Jan 10, 2020

Renaming files that exist in 3.x also won't work. See discussion #23725.

@wilsonge
Copy link
Contributor

Case sensitive renaming definitely doesn't work 'as is' because the upgrades from 3.x will fail. @HLeithner was going to investigate a way of being able to do this which would unblock this PR

@brianteeman
Copy link
Contributor Author

@HLeithner anything ?

@HLeithner
Copy link
Member

Not ready yet...

@brianteeman
Copy link
Contributor Author

@HLeithner just checking in to see if there has been any progress

@zero-24
Copy link
Contributor

zero-24 commented May 25, 2020

@PhilETaylor

This comment was marked as abuse.

@brianteeman
Copy link
Contributor Author

No point in me fixing the conflicts until @HLeithner delivers his code

@HLeithner HLeithner self-assigned this Sep 25, 2020
@jwaisner
Copy link
Member

@HLeithner checking to see if the required code has been completed for this to be able to move forward.

@wilsonge
Copy link
Contributor

Closing in favour of #31804 which should rename the files correctly

@wilsonge wilsonge closed this Dec 30, 2020
@brianteeman brianteeman deleted the psr4 branch September 19, 2021 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants